Merge lp://staging/~ralsina/ubuntu-push-qml/unpack-tags into lp://staging/ubuntu-push-qml
Proposed by
Roberto Alsina
Status: | Merged |
---|---|
Approved by: | Roberto Alsina |
Approved revision: | 12 |
Merged at revision: | 10 |
Proposed branch: | lp://staging/~ralsina/ubuntu-push-qml/unpack-tags |
Merge into: | lp://staging/ubuntu-push-qml |
Diff against target: |
15 lines (+4/-1) 1 file modified
src/Ubuntu/PushNotifications/pushclient.cpp (+4/-1) |
To merge this branch: | bzr merge lp://staging/~ralsina/ubuntu-push-qml/unpack-tags |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Michał Karnicki (community) | Approve | ||
Review via email: mp+239441@code.staging.launchpad.net |
Commit message
Expand tags before passing them to clearPersistent
Description of the change
Expand tags before passing them to clearPersistent
To test:
Install hello app.
Edit main.qml and change
}
to
}
Start the app, make sure it doesn't crash push-client.
To post a comment you must log in.
FAILED: Continuous integration, rev:11 jenkins. qa.ubuntu. com/job/ ubuntu- push-qml- ci/25/ jenkins. qa.ubuntu. com/job/ ubuntu- push-qml- utopic- amd64-ci/ 25/console jenkins. qa.ubuntu. com/job/ ubuntu- push-qml- utopic- armhf-ci/ 25/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- push-qml- ci/25/rebuild
http://