Merge lp://staging/~ralsina/account-polld/use-webapp-ids-respect-blacklist into lp://staging/~ubuntu-push-hackers/account-polld/trunk

Proposed by Roberto Alsina
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 95
Merged at revision: 94
Proposed branch: lp://staging/~ralsina/account-polld/use-webapp-ids-respect-blacklist
Merge into: lp://staging/~ubuntu-push-hackers/account-polld/trunk
Diff against target: 166 lines (+17/-68)
8 files modified
cmd/account-polld/account_manager.go (+9/-0)
cmd/account-polld/main.go (+8/-5)
data/account-polld.application (+0/-12)
data/account-polld.service-type (+0/-7)
data/facebook-poll.service (+0/-8)
data/google-gmail-poll.service (+0/-19)
data/twitter-poll.service (+0/-8)
debian/rules (+0/-9)
To merge this branch: bzr merge lp://staging/~ralsina/account-polld/use-webapp-ids-respect-blacklist
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Alberto Mardegan (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+236885@code.staging.launchpad.net

Commit message

* Use identifiers and API keys provided by the respective webapps which are the official end points for the notifications
* Respect blacklist gsetting to skip polling for notifications that are not going to be shown

Description of the change

* Use identifiers and API keys provided by the respective webapps which are the official end points for the notifications

* Respect blacklist gsetting to skip polling for notifications that are not going to be shown

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

The changes related to OA look fine.

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

LGTM, approving based on testing by others

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches