Merge lp://staging/~rakete/eidete/no-duration-fix into lp://staging/eidete
Proposed by
Andreas Raster
| Status: | Merged |
|---|---|
| Merge reported by: | Tom Beckmann |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~rakete/eidete/no-duration-fix |
| Merge into: | lp://staging/eidete |
| Diff against target: |
78 lines (+23/-14) 1 file modified
src/eidete.vala (+23/-14) |
| To merge this branch: | bzr merge lp://staging/~rakete/eidete/no-duration-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tom Beckmann (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Someone in #gstreamer helped me figure it out. We need to manually send an EOS to the pipeline and wait for it to finish writing everything to disk before setting it to NULL. That fixes the duration problem, and it is even the correct way and not some ugly hack.
Still, please test before merging, changed when the main_window gets deleted.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks a lot, in my tests the main_window was never delted, so I added the call after the enddialog is shown, besides this everything works perfectly. Great work!
We may want to consider a little progress dialog, but it doesn't seem to be that urgent, I will report it as low priority bug.