Juju Charms Collection
swift-proxy package

Merge lp://staging/~raharper/charms/trusty/swift-proxy/next-unique-get-zone into lp://staging/~openstack-charmers-archive/charms/trusty/swift-proxy/next

  1. Trusty Tahr (14.04)
  2. next-unique-get-zone
  3. Merge into next
Proposed by Corey Bryant
Status: Merged
Merged at revision: 55
Proposed branch: lp://staging/~raharper/charms/trusty/swift-proxy/next-unique-get-zone
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/swift-proxy/next
Diff against target: 20 lines (+8/-2)
1 file modified
hooks/swift_utils.py (+8/-2)
To merge this branch: bzr merge lp://staging/~raharper/charms/trusty/swift-proxy/next-unique-get-zone
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+227090@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Looks good to me.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Actually, one comment. It'd probably be useful to reference the bug in your commit. e.g. bzr commit --fixes lp:1342891 hooks/swift_utils.py

Revision history for this message
Ryan Harper (raharper) wrote :

I did that in my branch:

------------------------------------------------------------
revno: 54
fixes bug: https://launchpad.net/bugs/1342891
committer: Ryan Harper <email address hidden>
branch nick: next-fix-1342891
timestamp: Wed 2014-07-16 14:07:14 -0500
message:
  uniquify swift-storage device list for zone calculation.

This should show up after merging the branch with:

bzr log -n 0 | less

On Wed, Jul 16, 2014 at 2:30 PM, Corey Bryant <email address hidden>
wrote:

> Actually, one comment. It'd probably be useful to reference the bug in
> your commit. e.g. bzr commit --fixes lp:1342891 hooks/swift_utils.py
> --
>
> https://code.launchpad.net/~raharper/charms/trusty/swift-proxy/next-unique-get-zone/+merge/227090
> You are the owner of
> lp:~raharper/charms/trusty/swift-proxy/next-unique-get-zone.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches