Merge lp://staging/~rafalcieslak256/ubuntu-accomplishments-viewer/982246 into lp://staging/ubuntu-accomplishments-viewer
Status: | Merged |
---|---|
Merged at revision: | 10 |
Proposed branch: | lp://staging/~rafalcieslak256/ubuntu-accomplishments-viewer/982246 |
Merge into: | lp://staging/ubuntu-accomplishments-viewer |
Diff against target: |
29 lines (+12/-0) 1 file modified
bin/accomplishments-viewer (+12/-0) |
To merge this branch: | bzr merge lp://staging/~rafalcieslak256/ubuntu-accomplishments-viewer/982246 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jono Bacon | Pending | ||
Review via email: mp+102031@code.staging.launchpad.net |
Description of the change
This branch is meant to fix #982246 in the viewer, by introducing proper PATH setting.
This merge is related to https:/
The client-side fix turned out to be much simpler, as it is enough to repair the PATH in bin/accomplishm
===
That change introduces one more great feature:
It is now possible to pair a certain version of daemon/client. By installing BOTH the daemon and client to the same directory one can be sure that the client will use the api files from exactly that daemon installation.
Also, although I have not checked it because I do not have these packaging scripts, I think it may be beneficial when it comes to packaging. I'm unsure of how it works with python, but e.g. autotools love to set their custom prefix for packages, and supporting that within the app's code is a desired feature.
===
The next step would be to fix #982047 so that it works not only in packages, but in any installation :-)