Merge lp://staging/~rafalcieslak256/ubuntu-accomplishments-viewer/982246 into lp://staging/ubuntu-accomplishments-viewer

Proposed by Rafał Cieślak
Status: Merged
Merged at revision: 10
Proposed branch: lp://staging/~rafalcieslak256/ubuntu-accomplishments-viewer/982246
Merge into: lp://staging/ubuntu-accomplishments-viewer
Diff against target: 29 lines (+12/-0)
1 file modified
bin/accomplishments-viewer (+12/-0)
To merge this branch: bzr merge lp://staging/~rafalcieslak256/ubuntu-accomplishments-viewer/982246
Reviewer Review Type Date Requested Status
Jono Bacon Pending
Review via email: mp+102031@code.staging.launchpad.net

Description of the change

This branch is meant to fix #982246 in the viewer, by introducing proper PATH setting.

This merge is related to https://code.launchpad.net/~rafalcieslak256/ubuntu-accomplishments-daemon/982246/+merge/102030, it fixes the same problem in the daemon.

The client-side fix turned out to be much simpler, as it is enough to repair the PATH in bin/accomplishment-viewer launcher. The problem was that the launcher was setting the path correctly only if it was installed to /opt/extras.ubuntu.com/accomplishments-viewer, I made it simply add the required locations based on PROJECT_ROOT_DIRECTORY.

===
That change introduces one more great feature:
It is now possible to pair a certain version of daemon/client. By installing BOTH the daemon and client to the same directory one can be sure that the client will use the api files from exactly that daemon installation.

Also, although I have not checked it because I do not have these packaging scripts, I think it may be beneficial when it comes to packaging. I'm unsure of how it works with python, but e.g. autotools love to set their custom prefix for packages, and supporting that within the app's code is a desired feature.

===
The next step would be to fix #982047 so that it works not only in packages, but in any installation :-)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: