lp://staging/~radix/landscape-client/reactor-refactor-2

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://staging/~landscape/landscape-client/trunk

Alberto Donato: Approve on 2013-05-17

Free Ekanayaka (community): Approve on 2013-05-16

Diff: 515 lines (+94/-53)

19 files modified

landscape/amp.py (+3/-2)
landscape/broker/client.py (+2/-1)
landscape/broker/service.py (+1/-1)
landscape/broker/tests/helpers.py (+7/-4)
landscape/broker/tests/test_service.py (+2/-1)
landscape/manager/manager.py (+2/-3)
landscape/manager/service.py (+3/-3)
landscape/manager/tests/test_service.py (+2/-1)
landscape/manager/usermanager.py (+2/-2)
landscape/monitor/monitor.py (+3/-4)
landscape/monitor/service.py (+4/-3)
landscape/monitor/tests/test_monitor.py (+2/-1)
landscape/monitor/tests/test_service.py (+2/-1)
landscape/monitor/tests/test_usermonitor.py (+2/-1)
landscape/monitor/usermonitor.py (+2/-1)
landscape/reactor.py (+31/-14)
landscape/service.py (+4/-0)
landscape/tests/helpers.py (+7/-3)
landscape/tests/test_amp.py (+13/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1180591: make ComponentPublisher use the twisted reactor

Medium

Invalid

Link a bug report

Related blueprints

682. By Christopher Armstrong on 2013-05-16

merge from trunk

681. By Christopher Armstrong on 2013-05-15

lint

680. By Christopher Armstrong on 2013-05-15

revert an unrelated part of the remove-reactor refactoring (still needs to happen, but not in this branch)

679. By Christopher Armstrong on 2013-05-15

holy crap... all the tests pass.

678. By Christopher Armstrong on 2013-05-14

- get rid of a pointless/untested KeyboardInterrupt handling clause which
  added a dependency of the event handling code on the reactor
- add an EventSystem class which only provides event logic, not reactor
  interfaces

677. By Christopher Armstrong on 2013-05-14

lint

676. By Christopher Armstrong on 2013-05-14

rename TwistedReactor to LandscapeReactor.

675. By Christopher Armstrong on 2013-05-14

Merge remove-component-publisher-subclasses [f=] [r=tribaal,free.ekanayaka] [a=Christopher Armstrong]
Simplify publishing of AMP objects by doing two things:

- get rid of the necessity of subclassing ComponentPublisher
- allow implementations of brokered objects to use a @remote decorator to declare which methods should be exposed over AMP.

674. By Free Ekanayaka on 2013-05-14

Merge amp-test-readability [f=1170669] [r=tribaal,radix] [a=Free Ekanayaka]
This is the last branch I have around cleaning up the AMP-based machinery in the client. It essentially just change the tests:

- Drop the Words class, which had a bunch of ad-hoc methods used to exercise the behavior of the MethodCall protocol. Essentially each method was associated with a test, but the context was not clear by reading the test itself (you'd have to go and read the implementation in the Words class).

- Modify most methods to define the remotely-exposed method being tested, so the context is clear.

- Partially re-wrote RemoteObjectTest, which had a bunch of tests which were only duplicating tests from MethodCallTest. Now this test class has only tests that are really specific to RemoteObject.

673. By Christopher Armstrong on 2013-05-09

Merge retry-package-ops [f=1177419] [r=free.ekanayaka,jseutter] [a=Christopher Armstrong]
Package installation failures, including failures to acquire the apt lock, are now retried a number of times with a delay in between.