Merge lp://staging/~qzhang/lava-dispatcher/fix-apt-proxy-failure into lp://staging/lava-dispatcher

Proposed by Spring Zhang
Status: Merged
Merged at revision: 361
Proposed branch: lp://staging/~qzhang/lava-dispatcher/fix-apt-proxy-failure
Merge into: lp://staging/lava-dispatcher
Diff against target: 109 lines (+15/-23)
3 files modified
lava_dispatcher/actions/lava-test.py (+10/-12)
lava_dispatcher/client/base.py (+4/-7)
lava_dispatcher/context.py (+1/-4)
To merge this branch: bzr merge lp://staging/~qzhang/lava-dispatcher/fix-apt-proxy-failure
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Spring Zhang (community) Needs Resubmitting
Review via email: mp+117304@code.staging.launchpad.net

Description of the change

According to asac's suggestion, use apt-get -o Acquire::http::proxy= to replace configuration file 30proxy

Added a member in LavaClient.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

This is a bit of bike-shedding, but making the member variable "apt-get_cmd" feels weird. How about "aptget_cmd" or "apt_get_cmd" the dash character just seems odd.

362. By Spring Zhang

delete dash in member name

Revision history for this message
Spring Zhang (qzhang) wrote :

ok, my intention is make 'apt-get' searchable. I've renamed it to 'aptget_cmd'

review: Needs Resubmitting
Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches