Merge lp://staging/~qzhang/lava-dispatcher/fix-833246 into lp://staging/lava-dispatcher
Proposed by
Spring Zhang
| Status: | Merged |
|---|---|
| Merged at revision: | 101 |
| Proposed branch: | lp://staging/~qzhang/lava-dispatcher/fix-833246 |
| Merge into: | lp://staging/lava-dispatcher |
| Diff against target: |
109 lines (+41/-33) 2 files modified
lava_dispatcher/actions/launch_control.py (+40/-32) lava_dispatcher/client.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~qzhang/lava-dispatcher/fix-833246 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Larson (community) | Needs Fixing | ||
| Spring Zhang (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
1. fix 833246, [submit lava results including gather_results for all jobs]
2. Add a test run entry 'submit_result' if getting master ip fails. It will be pushed to dashboard. If everything is ok, no such entry appears.
To post a comment you must log in.
Revision history for this message
| Spring Zhang (qzhang) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is already merged it seems, and I just now dug through my post-holiday email enough to find it (was out yesterday). Just giving it a quick glance, the first thing that jumps out at me is:
78 + # add submit_results failure info if no available network to get test
79 + # case result
80 + if master_ip == None:
81 + err_msg = "Getting master image IP address failed, \
82 +no test case result retrived."
83 + self.context.
I don't think that was really the intent. In fact, the bug specifically says "gather_results"
I think, if we have *any* results in the dashboard, then we can reasonably conclude that the results were submitted ok :)
Next, you seem to be using the fact that master_ip == None to determine that there was a problem. Couldn't we have other problems that should trigger us to have a gathers_
Also, it doesn't look like we ever create a 'pass' version of this if we do successfully gather all the results.