Merge lp://staging/~qzhang/lava-dispatcher/fix-1025829 into lp://staging/lava-dispatcher
Proposed by
Spring Zhang
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 357 | ||||
| Proposed branch: | lp://staging/~qzhang/lava-dispatcher/fix-1025829 | ||||
| Merge into: | lp://staging/lava-dispatcher | ||||
| Diff against target: |
34 lines (+5/-8) 2 files modified
lava_dispatcher/actions/lava-test.py (+3/-3) lava_dispatcher/client/base.py (+2/-5) |
||||
| To merge this branch: | bzr merge lp://staging/~qzhang/lava-dispatcher/fix-1025829 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andy Doan (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix Bug #1025829, previous 'cat' cmd is for checking, it's ok to remove it.
Also, use delete the proxy config file instead of empty the file, seems 'echo' command is not reliable in proxy file creation.
To post a comment you must log in.
Revision history for this message
| Andy Doan (doanac) wrote | # |
Revision history for this message
| Spring Zhang (qzhang) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think we should go ahead and add logic to not set the proxy if one is not configured. ie, don't just echo an empty string to the file.