Merge lp://staging/~qzhang/lava-dispatcher/dispatcher-plars into lp://staging/lava-dispatcher

Proposed by Spring Zhang
Status: Rejected
Rejected by: Michael Hudson-Doyle
Proposed branch: lp://staging/~qzhang/lava-dispatcher/dispatcher-plars
Merge into: lp://staging/lava-dispatcher
Diff against target: 461 lines (+412/-0) (has conflicts)
9 files modified
imx51evk.json (+35/-0)
lava-dispatch (+18/-0)
lava/actions/__init__.py (+26/-0)
lava/actions/abrek.py (+6/-0)
lava/actions/boot_control.py (+14/-0)
lava/actions/deploy.py (+154/-0)
lava/actions/launch_control.py (+6/-0)
lava/client.py (+118/-0)
test.json (+35/-0)
Conflict adding file lava-dispatch.  Moved existing file to lava-dispatch.moved.
Conflict adding file lava.  Moved existing file to lava.moved.
To merge this branch: bzr merge lp://staging/~qzhang/lava-dispatcher/dispatcher-plars
Reviewer Review Type Date Requested Status
Paul Larson (community) Disapprove
Review via email: mp+51112@code.staging.launchpad.net

Description of the change

Some code for implementation of generating test image tarball based on Paul's dispatcher code.

Something still need to enhance:
1. call l-m-c by python way
2. find a better way for tar in relative path and command, maybe tarfile
3. a way to execute a series shell commands

To post a comment you must log in.
Revision history for this message
Spring Zhang (qzhang) wrote :

Sorry I sent a code merge including Paul's initial code and my changing by:
pull lp:~pwlars/lava/lava-dispatch-example1/
push lp:~qzhang/lava/dispatcher-plars
do my changing
merge lp:~pwlars/lava/lava-dispatch-example1/

I choose to merge my code to Paul's branch but I'm confused it is merged to
lp:lava now.

I attach a diff file of my changing for you to review.
You can refer to
https://code.launchpad.net/~qzhang/lava/dispatcher-plars/+merge/51112<https://code.launchpad.net/%7Eqzhang/lava/dispatcher-plars/+merge/51112>

8. By Spring Zhang

Merge pwlars v3:
  Paul Larson 2011-02-24 rename interfaces directory to actions
    Paul Larson 2011-02-24 random cleanups

Revision history for this message
Loïc Minier (lool) wrote :

This branch doesn't seem to derive from the current lp:lava; how was it created?!?

Revision history for this message
Spring Zhang (qzhang) wrote :

On Sat, 2011-02-26 at 23:58 +0000, Loïc Minier wrote:
> This branch doesn't seem to derive from the current lp:lava; how was it created?!?

It's derived and based on Paul's lava-dispatch-example1, and I add some
code and request to merge back to ~pwlars/lava/lava-dispatch-example1.

--
Best wishes,
Spring Zhang

9. By Spring Zhang

fix LavaClient2 to LavaClient

Revision history for this message
Paul Larson (pwlars) wrote :

Hi spring, as we discussed before, it would be helpful if you could re-diff this against trunk now that it's been switched out. We can restart from there.

review: Disapprove
Revision history for this message
Spring Zhang (qzhang) wrote :

Yes, I have checked the new lp:lava, will base on it.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I don't think this is relevant any more.

Unmerged revisions

9. By Spring Zhang

fix LavaClient2 to LavaClient

8. By Spring Zhang

Merge pwlars v3:
  Paul Larson 2011-02-24 rename interfaces directory to actions
    Paul Larson 2011-02-24 random cleanups

7. By Spring Zhang

implement generate_tarballs(), the function to generate test image tarball

6. By Spring Zhang

include BOARD_TYPE in LavaClient2 for reuse

5. By Spring Zhang

fix typo error

4. By Spring Zhang

change back to http server

3. By Spring Zhang

fix import error

2. By Spring Zhang

1. add imx51evk test job
2. imx51evk job: use a local rootfs/hwpack path

1. By Paul Larson

First attempt at a simplified dispatcher example

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches