Merge lp://staging/~qzhang/lava-dispatcher/add-mx53-android into lp://staging/lava-dispatcher

Yongqin,
Could you have a try on panda for I added some config to config file, I don't know if it will break.
Thank you!

retested with normal image and mx53 android image by boot test image action after fix bug 889030 and merge with mainline

25 + # Original android sdcard layout
26 + part_no = client.device_option("android_org_sys_part")
27 + org_sys_part = part_no if part_no else 2
28 + part_no = client.device_option("android_org_cache_part")
29 + org_cache_part = part_no if part_no else 3
30 + part_no = client.device_option("android_org_data_part")
31 + org_data_part = part_no if part_no else 5
32 + # Sdcard layout in Lava image
33 + part_no = client.device_option("android_lava_sys_part")
34 + lava_sys_part = part_no if part_no else 5
Since we are making conf options out of the partitions, it might be best to have these configed as defaults rather than hardcoding them in the source

170 +android_org_boot_part = 2
171 +android_org_sys_part = 3
172 +android_org_cache_part = 5
173 +android_org_data_part = 6
174 +android_org_sdcard_part = 7
175 +android_lava_sys_part = 6
176 +android_lava_sdcard_part = 7
177 +boot_cmds_android = mmc init,
While your at it, for the mx53 as well as the one in default, these should have comments and/or better names. These are confusing to me. For instance, what's the difference between android_org_sys_part and android_lava_sys_part?

51 + client.run_cmd_master('sed -i "s/mmcblk0p%s/mmcblk0p%s/g" init.rc'
52 + % (org_sys_part, lava_sys_part))
ah, I see, it looks like the android_org_* is what you are changing it *from* in the image. I'm not sure this belongs in a config option in that case. This config is describing things that are specific to this board. However, you are talking about a string that is specific to the image and has nothing to do with the board itself right?

115 + self.proc.expect(shell_str)
does this line has meaning?
if we don't check the result of this sentence here, may be we can delete this sentence.

in file lava_dispatcher/default-config/lava-dispatcher/device-types/mx53loco.conf,

there are original definition of partition number
> boot_part = 2
> root_part = 3
these seems to be duplicate to the lines below:
170 +android_org_boot_part = 2
171 +android_org_sys_part = 3

others seems ok.

> Yongqin,
> Could you have a try on panda for I added some config to config file, I don't
> know if it will break.
> Thank you!

Sorry, I just saw this today, I will try it later. And I will notify you the result after the test.

> > Yongqin,
> > Could you have a try on panda for I added some config to config file, I
> don't
> > know if it will break.
> > Thank you!
>
> Sorry, I just saw this today, I will try it later. And I will notify you the
> result after the test.
It's fine, still in fixing some comments from Paul, thanks.

Add default config to Paul's comments.

> in file lava_dispatcher/default-config/lava-dispatcher/device-
> types/mx53loco.conf,
>
> there are original definition of partition number
> > boot_part = 2
> > root_part = 3
> these seems to be duplicate to the lines below:
> 170 +android_org_boot_part = 2
> 171 +android_org_sys_part = 3
>
> others seems ok.
I wish to separate them to avoid future confusion, and the former pairs are using to generate an image file by l-m-c.

> 115 + self.proc.expect(shell_str)
> does this line has meaning?
> if we don't check the result of this sentence here, may be we can delete this
> sentence.
You are pointing out a way to reduce the code, I'm considering if it is used for waiting for a shell prompt to execute next command, if we don't expect a master/test string, we can make the method available everywhere(both master and test image)

Delete shell prompt expected string to wait_network_up available to master/test image.

Delete shell prompt expected string to wait_network_up available to master/test image.

I plan to test it on panda this afternoon, begin at 16th Nov, 13:00 UTC+8
after test, if there is no problem I will approve this.

I used staging-panda/90 for test.
and execute monkey/busybox/0xbench test on the image. There is no problem.
The link below is the result.
http://validation.linaro.org/lava-server/dashboard/streams/anonymous/lava-android-leb-panda/bundles/b6a0f5605220c2fef78ab03990eb654ffc68fcad/