Merge lp://staging/~quickly-committers/quickly/702153 into lp://staging/quickly
Proposed by
Michael Terry
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~quickly-committers/quickly/702153 |
| Merge into: | lp://staging/quickly |
| Diff against target: |
89 lines (+48/-3) 3 files modified
quickly/builtincommands.py (+10/-1) quickly/templatetools.py (+23/-2) quickly/test/quickly.sh (+15/-0) |
| To merge this branch: | bzr merge lp://staging/~quickly-committers/quickly/702153 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tony Byrne | Needs Fixing | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Michael Terry (mterry) wrote | # |
Unmerged revisions
- 622. By Michael Terry
-
when creating a project, record version of parent templates
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Michael
I looked at this quite a while ago and couldn't make up my mind if is was a bug or not. We will agree it is a bug because it generates a false error message.
If the derived template was produced by an earlier version of quickly we would like to call upgrade on the project. Quickly marks *all* projects for upgrade that are created from derived templates, probably because it is difficult to discover which version of quickly produced the template.
templatetools contains the comment
# initialize with an empty project version to force first upgrade
Calling upgrade fails for templates produced by version 11.04 because it expects old code to be present in the project. I added a patch to https:/
I've marked this branch as needs fixing because I suspect that it will skip upgrade for old templates in ~/quickly-