Ubuntu Shorts App

Merge lp://staging/~qqworini/ubuntu-rssreader-app/swipe-remove-and-drag-n-drop into lp://staging/~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

  1. swipe-remove-and-drag-n-drop
  2. Merge into trunk
Proposed by Joey Chan
Status: Merged
Approved by: Roman Shchekin
Approved revision: 88
Merged at revision: 93
Proposed branch: lp://staging/~qqworini/ubuntu-rssreader-app/swipe-remove-and-drag-n-drop
Merge into: lp://staging/~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 807 lines (+490/-71)
6 files modified
feeds/CreateTopicPage.qml (+4/-0)
feeds/EditFeed.qml (+12/-1)
feeds/SwipeDelete.qml (+118/-0)
feeds/TopicComponent.qml (+218/-61)
feeds/TopicManagement.qml (+106/-5)
rssreader-app.qml (+32/-4)
To merge this branch: bzr merge lp://staging/~qqworini/ubuntu-rssreader-app/swipe-remove-and-drag-n-drop
Reviewer Review Type Date Requested Status
David Planella Needs Information
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+189312@code.staging.launchpad.net

Commit message

swipe-remove and drag&drop done, with many related optimization

1. swipe-remove component is from music-app;
*2. most complicated implementation of drag&drop in the world;
3. optimize the input field position;
4. fix for bug #1234766

Description of the change

swipe-remove and drag&drop done, with many related optimization

1. swipe-remove component is from music-app;
*2. most complicated implementation of drag&drop in the world;
3. optimize the input field position;
4. fix for bug #1234766

PS: why do I say "most complicated implementation of drag&drop in the world"? because there are many issues will lead to crash in device, such as Drag.active, or some issues will cause "Detectable autorepeat not supported" error. I need to avoid all of them to make these features possible, how? I calculate all x,y value every time & everywhere.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:88
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/73/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/668
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-precise-amd64-ci/73
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-quantal-amd64-ci/73
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-raring-amd64-ci/73
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-saucy-amd64-ci/73

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/73/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Roman Shchekin (mrqtros) wrote :

You have done very ..."painful" work, Joey :))

But - on device swipe-to-remove topic work without any animation, with delay about 1 sec, so I removed 2 topics instead of one (sad, it was art topic :( ). Is it ok? :)

Revision history for this message
Joey Chan (qqworini) wrote :

The topic item is standard SDK listitem, so maybe that's a bug of SDK, not me :P

> You have done very ..."painful" work, Joey :))
>
> But - on device swipe-to-remove topic work without any animation, with delay
> about 1 sec, so I removed 2 topics instead of one (sad, it was art topic :( ).
> Is it ok? :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Looking at the status of bug 1213046 [1], it seems like the swipe delete pattern has been implemented in the SDK (but it might not have landed yet). Would it be possible to use that instead?

[1] https://bugs.launchpad.net/address-book-app/+bug/1213046

review: Needs Information
Revision history for this message
Joey Chan (qqworini) wrote :

I'm not sure If I can use it, depends on whether it is still one of the "ListItem" OR an independent component without any build-in MouseArea(may prevent using drag event)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches