Ubuntu Test Runlists

Merge lp://staging/~pwlars/ubuntu-test-runlists/jenkins-smoketest-setup-mark-current into lp://staging/~canonical-ci-engineering/ubuntu-test-runlists/jenkins-smoketest-setup

  1. jenkins-smoketest-setup-mark-current
  2. Merge into jenkins-smoketest-setup
Proposed by Paul Larson
Status: Merged
Merged at revision: 49
Proposed branch: lp://staging/~pwlars/ubuntu-test-runlists/jenkins-smoketest-setup-mark-current
Merge into: lp://staging/~canonical-ci-engineering/ubuntu-test-runlists/jenkins-smoketest-setup
Diff against target: 66 lines (+33/-0)
2 files modified
setup-jobs.py (+5/-0)
templates/smoke.xml.jinja (+28/-0)
To merge this branch: bzr merge lp://staging/~pwlars/ubuntu-test-runlists/jenkins-smoketest-setup-mark-current
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+161656@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

This looks reasonable to me. Is mark-pending-current already setup, or does it make sense to have a template for that as well?

Revision history for this message
Paul Larson (pwlars) wrote :

That job already exists, it's a parameterized job that gets used by anything that needs to trigger a pending->current transition, you just have to feed it the product, arch, etc.
It's not included in a template here right now, could add it if needs be, but it's not something that needs to get recreated for each release - it will work fine for any release.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I think it would be nice to have a template at some point in case we need to recreate the setup in another environment, or the current jenkins instance catches fire, etc. It doesn't need to be there, though, so I think we can merge without it.

review: Approve
Revision history for this message
Javier Collado (javier.collado) wrote :

Looks good to me (but difficult to read because of all the entities in the xml).

I also think that mark-pending-current should be included in the branch, so that everything could be recreated if needed in the future.

Revision history for this message
Paul Larson (pwlars) wrote :

Oops, didn't see your last comment until after I pushed it. I'll add it in another branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: