Ubuntu CI Services

Merge lp://staging/~pwlars/ubuntu-ci-services-itself/imagebuild-keystone-auth-fix into lp://staging/ubuntu-ci-services-itself

  1. imagebuild-keystone-auth-fix
  2. Merge into trunk
Proposed by Paul Larson
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 308
Merged at revision: 313
Proposed branch: lp://staging/~pwlars/ubuntu-ci-services-itself/imagebuild-keystone-auth-fix
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 27 lines (+12/-4)
1 file modified
ci-utils/ci_utils/image_store/__init__.py (+12/-4)
To merge this branch: bzr merge lp://staging/~pwlars/ubuntu-ci-services-itself/imagebuild-keystone-auth-fix
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Paul Larson Needs Resubmitting
Review via email: mp+209314@code.staging.launchpad.net

Commit message

Fixes endpoint lookup from keystone if you are using older keystoneclient versions (LP:1287203)

Description of the change

Fixes endpoint lookup from keystone if you are using older keystoneclient versions (LP:1287203). I also tried this same method with the newer (0.6.0) keystone client and it worked there.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:307
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/287/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/287/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~pwlars/ubuntu-ci-services-itself/imagebuild-keystone-auth-fix updated
308. By Paul Larson

flake8 fix

Revision history for this message
Paul Larson (pwlars) :
review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:308
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/294/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/294/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

adding vila the review since i've never hit the issue. seems fine.

Revision history for this message
Paul Larson (pwlars) wrote :

fwiw, I did test this with both the 0.3.0 packaged version of keystoneclient, as well as the 0.6.0 pypi package locally, and I ran it through several times in hpcloud today with success.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Yeah for robustness !

Nit (no need to fix that for now):

18 + raise ImageStoreException(
19 + 'No valid glance endpoints found for the specified region. '
20 + 'Check that the cloud credentials specified are valid')

Expanding 'endpoints' and 'region' could help diagnosis.

We know there is no glance endpoints, but having the existing endpoints (even empty) could give us some hints.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches