Merge ~pwlars/revcache/+git/revcache-charm:change-config-location into ~canonical-hw-cert/revcache/+git/revcache-charm:master
Proposed by
Paul Larson
| Status: | Merged |
|---|---|
| Approved by: | Paul Larson |
| Approved revision: | e1e1c48eb9b3b5c78e2c4b2cb127ad02a7bcca4b |
| Merged at revision: | 1416bab6c72107030926349d478497567247d6ef |
| Proposed branch: | ~pwlars/revcache/+git/revcache-charm:change-config-location |
| Merge into: | ~canonical-hw-cert/revcache/+git/revcache-charm:master |
| Diff against target: |
26 lines (+2/-2) 2 files modified
playbooks/revcache.yaml (+1/-1) templates/revcache.service (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
There's a chance that config-changed events can fire off at random times. If that happens, and we don't re-do the relation, then the revcache.conf file will get removed, leading to no valid config for reaching the redis server.
To post a comment you must log in.
Revision history for this message
| Paul Larson (pwlars) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I've tested this by making those changes by hand to our revcache server, and it's happy to pick up the config from the specified location. I can still send curl tests to it and get valid responses after removing the config from the other location and reloading the service