Merge ~pwlars/checkbox/+git/support:https-vs-git into ~checkbox-dev/checkbox/+git/support:master
| Status: | Merged |
|---|---|
| Approved by: | Paul Larson |
| Approved revision: | f45a6275a4bb9cabdc706cd99bcd6d9f760d5f58 |
| Merged at revision: | a9a6a1a100a0317d72c139d79dc928b50616557b |
| Proposed branch: | ~pwlars/checkbox/+git/support:https-vs-git |
| Merge into: | ~checkbox-dev/checkbox/+git/support:master |
| Diff against target: |
61 lines (+5/-5) 4 files modified
get-external-tarballs (+1/-1) install-pip-dependencies (+1/-1) install-pip-from-source (+1/-1) test-in-lxc.sh (+2/-2) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski (community) | Approve | ||
| Sylvain Pineau (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This *should* allow us to get pmr working in hwcert jenkaas. I tested it here by simulating what pmr-merge-hooks does with a modified version of checkbox support and it seems to work:
https:/
The best way to tell for certain will be to land this, and maybe a few related changes in other projects like the setup scripts, and give it a try with various projects. In any case, I don't see that this can hurt anything.
The main thing to watch out for, that could still break things in the future, is that we should always use https:// instead of git:// - this INCLUDES anything downstream that we pull, parts, etc. This is because https is friendly for proxies, but git:// is not, and we have to use the proxy when using the IS provided jenkins builders
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
+1 for the friendly method