Merge ~pwlars/checkbox/+git/support:lxc-attach-path into ~checkbox-dev/checkbox/+git/support:master
Proposed by
Paul Larson
| Status: | Merged |
|---|---|
| Approved by: | Paul Larson |
| Approved revision: | 6917aff70044b39b35800acad972c1d1c33331a4 |
| Merged at revision: | 12f705155e6bf7b2717a4097b1185d7e7224b022 |
| Proposed branch: | ~pwlars/checkbox/+git/support:lxc-attach-path |
| Merge into: | ~checkbox-dev/checkbox/+git/support:master |
| Diff against target: |
22 lines (+2/-2) 1 file modified
test-in-lxc.sh (+2/-2) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
I've managed to reproduce the errors I got when trying to run .pmr-merge-hooks from jenkins. It looks like because the jenkins user has a home dir in a weird location, the commands in lxc to run scripts from support to do things like fix permissions and run tests just fail silently because it doesn't set the working dir to the right place. Giving it a full path seems to fix it, even when using the jenkins user.
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Code reflects what you've described and seems sane.
+1