Merge lp://staging/~pundiramit/linaro-android-build-tools/labt into lp://staging/linaro-android-build-tools

Proposed by Amit Pundir
Status: Needs review
Proposed branch: lp://staging/~pundiramit/linaro-android-build-tools/labt
Merge into: lp://staging/linaro-android-build-tools
Diff against target: 42 lines (+22/-3)
1 file modified
build-scripts/create-user-build-script (+22/-3)
To merge this branch: bzr merge lp://staging/~pundiramit/linaro-android-build-tools/labt
Reviewer Review Type Date Requested Status
Данило Шеган (community) Needs Fixing
Review via email: mp+144239@code.staging.launchpad.net

Description of the change

Fix build error when Source_Overlay is not set.

To post a comment you must log in.
554. By Amit Pundir

linaro_android_build_cmds: prompt for access-id when syncing from private manifests

Revision history for this message
Данило Шеган (danilo) wrote :

This is a bit confusing. We require SOURCE_OVERLAY to be set (this was a recent change, so that's perhaps why it feels like a regression), for BUILD-INFO.txt file to be generated. Otherwise, someone can circum-vent our protection mechanisms (and more likely, build results will simply be inaccessible).

Then, this branch also deals with access to private repositories, but I am not sure I understand exactly what's going on. Can you please clarify the rationale for the changes?

review: Needs Information
Revision history for this message
Amit Pundir (pundiramit) wrote :

Making SOURCE_OVERLAY optional is a requirement from Android platform team and yes we may have overlooked certain things which you pointed out. I'll get back to you on this in a while.

Meanwhile I'll upload "access to private manifest repositories" changes to a new branch.

Revision history for this message
Данило Шеган (danilo) wrote :

Ok, I've discussed this with Vishal: the goal of this is to enable produced linaro_android_build_cmds.sh to work without the SOURCE_OVERLAY when not really needed. Since we do not use this script for actually building Android on jenkins, it's ok if this script has an override for SOURCE_OVERLAY (eg. perhaps set it to SOURCE_OVERLAY=ignore; if you want to do it any other way, that's fine as well).

However, the actual jenkins build should not allow that to be set in the build config (on android-build.linaro.org).

review: Needs Fixing

Unmerged revisions

554. By Amit Pundir

linaro_android_build_cmds: prompt for access-id when syncing from private manifests

553. By Amit Pundir

fix build error when overlay is not set

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches