Merge lp://staging/~pundiramit/linaro-android-build-tools/labt into lp://staging/linaro-android-build-tools
Proposed by
Amit Pundir
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~pundiramit/linaro-android-build-tools/labt |
Merge into: | lp://staging/linaro-android-build-tools |
Diff against target: |
42 lines (+22/-3) 1 file modified
build-scripts/create-user-build-script (+22/-3) |
To merge this branch: | bzr merge lp://staging/~pundiramit/linaro-android-build-tools/labt |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Needs Fixing | ||
Review via email: mp+144239@code.staging.launchpad.net |
Description of the change
Fix build error when Source_Overlay is not set.
To post a comment you must log in.
Unmerged revisions
- 554. By Amit Pundir
-
linaro_
android_ build_cmds: prompt for access-id when syncing from private manifests - 553. By Amit Pundir
-
fix build error when overlay is not set
This is a bit confusing. We require SOURCE_OVERLAY to be set (this was a recent change, so that's perhaps why it feels like a regression), for BUILD-INFO.txt file to be generated. Otherwise, someone can circum-vent our protection mechanisms (and more likely, build results will simply be inaccessible).
Then, this branch also deals with access to private repositories, but I am not sure I understand exactly what's going on. Can you please clarify the rationale for the changes?