Merge lp://staging/~psusi/ubuntu/natty/upower/sleep into lp://staging/ubuntu/natty/upower

Proposed by Phillip Susi
Status: Rejected
Rejected by: James Westby
Proposed branch: lp://staging/~psusi/ubuntu/natty/upower/sleep
Merge into: lp://staging/ubuntu/natty/upower
Diff against target: 153 lines (+124/-0)
4 files modified
debian/changelog (+8/-0)
debian/control (+1/-0)
debian/patches/add-signal-argument.patch (+114/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~psusi/ubuntu/natty/upower/sleep
Reviewer Review Type Date Requested Status
Chris Coulson (community) Disapprove
Evan Broder (community) Disapprove
Phillip Susi (community) Needs Resubmitting
Chris Halse Rogers Needs Fixing
Ubuntu branches Pending
Review via email: mp+54093@code.staging.launchpad.net

Description of the change

See linked bug report and related branches that all need merged together.

To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

You seem to have accidentally changed the copyright header in src/up-daemon.c; apart from that, looks good.

review: Needs Fixing
Revision history for this message
Phillip Susi (psusi) wrote :

Oops, good catch. Looks like my editor got a little excited about tabifying whitespace. I also had forgotten to add -pab --no-timestamps when freshing the quilt patch. Corrected.

review: Needs Resubmitting
20. By Phillip Susi

Add add-signal-argument.patch: Added missing argument to the
dbus Suspending/Resuming signal so g-p-m can apply the correct
policy. (LP: 578542)

Revision history for this message
Evan Broder (broder) wrote :

I disagree with changing an established and cross-distro D-Bus interface here.

And even though you fix g-p-m, I don't see patches for kdebase-workspace-bin or xfce4-power-manager. And even if you patched all of the utilities in the Ubuntu archive that used UPower, there could be any number of third-party programs that are expecting UPower to conform to its cross-distro definition (http://upower.freedesktop.org/docs/UPower.html).

The better approach here is to add a new signal that includes the argument, but leave the old signal alone, and that seems to be the conclusion that upstream is coming to as well.

review: Disapprove
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I agree with Evan here, and it's not clear whether hughsie agrees with this approach either (see http://lists.freedesktop.org/archives/devkit-devel/2011-March/001056.html). At this stage in the cycle, we shouldn't be breaking public dbus API's like this.

In addition to this, bypassing the upower client library reduces traceability (which is a big advantage of using client libraries to wrap dbus interfaces), and that traceability is required for problems exactly like this (ie, it's easy to find consumers of libupower and we have processes for library versioning if you want to break the API, but it's much more difficult to trace consumers of the raw dbus interface or properly version it if you want to break it).

review: Disapprove

Unmerged revisions

20. By Phillip Susi

Add add-signal-argument.patch: Added missing argument to the
dbus Suspending/Resuming signal so g-p-m can apply the correct
policy. (LP: 578542)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: