Merge lp://staging/~pskoli93/postorius/Helptext-Fixes into lp://staging/postorius

Proposed by Pavan Koli
Status: Needs review
Proposed branch: lp://staging/~pskoli93/postorius/Helptext-Fixes
Merge into: lp://staging/postorius
Diff against target: 50 lines (+35/-4)
1 file modified
src/postorius/views/user.py (+35/-4)
To merge this branch: bzr merge lp://staging/~pskoli93/postorius/Helptext-Fixes
Reviewer Review Type Date Requested Status
Mailman Coders Pending
Review via email: mp+257460@code.staging.launchpad.net

Description of the change

If we go to a list settings page and click on the question mark to open the more info tab, a new tab opens with an error that ListSettings is not defined globally.

Initially a ListSettings form was there but now different forms have been created for different list tasks like ListIdentityForm, ListAutomaticResponseForm etc. In all these forms if a user clicks on more info tab the 'formid' is equal to 'list_settings' and every form has the same 'formid', so there is no clear way to identify for which forms' option the more info is sought.

The solution to this is that a separate list(Python list) has been created for the separate forms with the 'helpid' stored in these lists(Python list). Now if a user clicks on more info tab we check which list(Python list) it corresponds to, by comparing the 'helpid', and then loading the appropriate help text from the appropriate form.

To post a comment you must log in.

Unmerged revisions

248. By pkoli <email address hidden>

Helptext fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches