Merge lp://staging/~pskoli93/postorius/Fixes into lp://staging/postorius

Proposed by Pavan Koli
Status: Rejected
Rejected by: Terri
Proposed branch: lp://staging/~pskoli93/postorius/Fixes
Merge into: lp://staging/postorius
Diff against target: 30 lines (+5/-5)
1 file modified
src/postorius/forms.py (+5/-5)
To merge this branch: bzr merge lp://staging/~pskoli93/postorius/Fixes
Reviewer Review Type Date Requested Status
Terri Disapprove
Review via email: mp+256107@code.staging.launchpad.net

Description of the change

Messages like 'Please a domain name' are being displayed for leaving the Mail Host and Web Host field blank while adding a new domain. Now they are fixed and the messages 'Please enter a Mail Host' and 'Please enter a Web Host' are displayed if the fields are kept blank.

To post a comment you must log in.
Revision history for this message
Terri (terriko) wrote :

Good idea, but probably more work for our translators that isn't super necessary at this point. Thanks for submitting, and sorry this one didn't work out!

review: Disapprove

Unmerged revisions

221. By pkoli <email address hidden>

Better messages added

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches