UTAH

Merge lp://staging/~psivaa/utah/utah-upgrade2 into lp://staging/~utah/utah/jenkins-upgradetest-setup

  1. utah-upgrade2
  2. Merge into jenkins-upgradetest-setup
Proposed by Para Siva
Status: Merged
Approved by: Max Brustkern
Approved revision: 44
Merged at revision: 25
Proposed branch: lp://staging/~psivaa/utah/utah-upgrade2
Merge into: lp://staging/~utah/utah/jenkins-upgradetest-setup
Diff against target: 893 lines (+763/-2)
22 files modified
jenkins/jenkins.sh (+2/-0)
main/install_main/install_all_main.py (+89/-0)
main/install_main/tc_control (+3/-2)
post-upgrade/README (+8/-0)
post-upgrade/conffiles/tc_control (+9/-0)
post-upgrade/conffiles/test_conffiles.py (+77/-0)
post-upgrade/debconf/debconf_test.py (+68/-0)
post-upgrade/debconf/tc_control (+9/-0)
post-upgrade/debsums/debsums_lite.py (+21/-0)
post-upgrade/debsums/tc_control (+9/-0)
post-upgrade/kernel/tc_control (+11/-0)
post-upgrade/kernel/test_kernel.py (+47/-0)
post-upgrade/lts_upgrade_system/tc_control (+11/-0)
post-upgrade/lts_upgrade_system/test_lts_upgrade_system.py (+73/-0)
post-upgrade/lts_upgrade_user/tc_control (+10/-0)
post-upgrade/lts_upgrade_user/test_lts_upgrade_user.py (+107/-0)
post-upgrade/python_import/tc_control (+10/-0)
post-upgrade/python_import/test_python_import.py (+131/-0)
post-upgrade/tslist.run (+7/-0)
post-upgrade/xserver/tc_control (+9/-0)
post-upgrade/xserver/test_xserver.py (+48/-0)
upgrade.run (+4/-0)
To merge this branch: bzr merge lp://staging/~psivaa/utah/utah-upgrade2
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Para Siva (community) Needs Resubmitting
Review via email: mp+179004@code.staging.launchpad.net

Description of the change

As per the comment in https://code.launchpad.net/~psivaa/utah/utah-upgrade/+merge/177884 and superseding it. Re-basing.
Contains the following changes:
1. Incorporate install_all_main.py rather than using it from the old location with some modification, for ease of maintenance
2. Changed the number of post upgrade tests
3. Added a line to destroy VMs at the end of the test.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Are you cleaning up the disks when destroying the machine?

Revision history for this message
Para Siva (psivaa) wrote :

I am not in favour of cleaning up the disks because that way we could manually restart the VM to investigate the VMs for any information that are not captured from the client logs in case of any failures. Destroying the VMs was introduced to reduce the processor load on the servers.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I forgot that 'destroy' in libvirt doesn't mean destroy in the way I usually think of it. Keeping them around for that makes sense.

On line 34, should redhat-cluster-suit be redhat-cluster-suite ?

Do the commented lines on 44, 52, 66, 74, and 176 need to stay in?

If it would be useful for the block starting on 629, we can work on doing a display-capable automated test, but I don't think that should hold up this merge.

post-upgrade/ts_control seems unnecessary since everything is commented out, but having it there as a placeholder isn't an unreasonable thing to do.

All of the actual important bits seem reasonable enough to me.

lp://staging/~psivaa/utah/utah-upgrade2 updated
44. By Para Siva

Fixing review comments bar the display-post upgrade test

Revision history for this message
Para Siva (psivaa) :
review: Needs Resubmitting
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Awesome!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: