Merge lp://staging/~psivaa/ubuntu-ci-services-itself/next-priv-ppa-page into lp://staging/ubuntu-ci-services-itself
Proposed by
Para Siva
| Status: | Merged |
|---|---|
| Approved by: | Para Siva |
| Approved revision: | 55 |
| Merged at revision: | 58 |
| Proposed branch: | lp://staging/~psivaa/ubuntu-ci-services-itself/next-priv-ppa-page |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
77 lines (+39/-8) 1 file modified
tests/ppa_assigner/test.py (+39/-8) |
| To merge this branch: | bzr merge lp://staging/~psivaa/ubuntu-ci-services-itself/next-priv-ppa-page |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Vincent Ladeuil (community) | Approve | ||
| Andy Doan (community) | Approve | ||
|
Review via email:
|
|||
Commit message
More tests for ppa-assigner
Description of the change
This adds three more basic tests for the juju environment. One is to check that the ppa name starts with ci-pool. The next couple of tests are testing the availability of next and previous pages.
To post a comment you must log in.
Revision history for this message
| Andy Doan (doanac) | # |
review:
Approve
Revision history for this message
| Para Siva (psivaa) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Well done !
Some tests sounds a bit verbose but it's ok for now, we can revisit that later (see my remarks on https:/
59 + url = 'http://{}:{}/api/
For example, tests shouldn't have to specify the http://{}:{}/api/v1/ppa part right ? They will always refer to that service (or if they don't for whatever reason, we still probably want that to be a test case attribute so we can easily parametrize running against various configurations).
But no need to address this *now* (quite the contrary in fact), let's keep collecting such uses to ensure we define the right helpers.