Merge lp://staging/~psivaa/snappy-proposed-image-tester/fix-pyflakes into lp://staging/snappy-proposed-image-tester

Proposed by Para Siva
Status: Merged
Approved by: Francis Ginther
Approved revision: 41
Merged at revision: 41
Proposed branch: lp://staging/~psivaa/snappy-proposed-image-tester/fix-pyflakes
Merge into: lp://staging/snappy-proposed-image-tester
Diff against target: 31 lines (+4/-8)
1 file modified
snappy_proposed_image_tester/worker.py (+4/-8)
To merge this branch: bzr merge lp://staging/~psivaa/snappy-proposed-image-tester/fix-pyflakes
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Celso Providelo Pending
Review via email: mp+260440@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-05-28.

Commit message

Name the results container and tarball based on the request_id and pass container and tarball names on to the result-checker.

Description of the change

Name the results container and tarball based on the request_id and pass container and tarball names on to the result-checker.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote : Posted in a previous version of this proposal

Francis,

Thanks for addressing this issue.

We discussed on IRC the necessity of unique tarball filenames by including the request_id (introduced in core-image-testing, adt-cloud uses results.tgz). We agreed that is a nice thing to have if several results get downloaded to the same path.

While I think it's still true for snappy-proposed, we want unique tarball filename, we will probably revisit this implementation to facilitate result aggregation based on our current talks with pitti.

review: Approve
Revision history for this message
Ubuntu CI Bot (uci-bot) wrote : Posted in a previous version of this proposal
Download full text (26.0 KiB)

The attempt to merge lp:~fginther/snappy-proposed-image-tester/update-container into lp:snappy-proposed-image-tester failed. Below is the output from the failed tests.

Using base prefix '/usr'
New python executable in /tmp/venv-snappy-proposed-image-testerfgyewk0l/bin/python3
Also creating executable in /tmp/venv-snappy-proposed-image-testerfgyewk0l/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python3
Ignoring indexes: https://pypi.python.org/simple/
Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 1))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 2))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerfgyewk0l/build/python-logstash/setup.py) egg_info for package python-logstash

Downloading/unpacking python-swiftclient==2.4.0 (from -r requirements.txt (line 3))
Downloading/unpacking python-keystoneclient==1.3.0 (from -r requirements.txt (line 4))
Downloading/unpacking uservice-utils==1.0.2.1 (from -r requirements.txt (line 5))
Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerfgyewk0l/build/anyjson/setup.py) egg_info for package anyjson

Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerfgyewk0l/build/amqp/setup.py) egg_info for package amqp

Downloading/unpacking futures>=2.1.3 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
Downloading/unpacking requests>=1.1 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
Downloading/unpacking simplejson>=2.0.9 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerfgyewk0l/build/simplejson/setup.py) egg_info for package simplejson

Downloading/unpacking six>=1.5.2 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
Downloading/unpacking oslo.config>=1.9.0 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking netaddr>=0.7.12 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking stevedore>=1.1.0 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking Babel>=1.3 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerfgyewk0l/build/Babel/setup.py) egg_info for package Babel

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
Downloading/unpacking iso8601>=0.1.9 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking oslo.serialization>=1.2.0 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking oslo.utils>=1.2.0 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking pbr>=0.6,!=0.7,<1.0 (from...

Revision history for this message
Francis Ginther (fginther) wrote :

psivaa, thanks for cleaning this up.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches