Merge lp://staging/~psivaa/jenkins-launchpad-plugin/stop-tmp-leak into lp://staging/jenkins-launchpad-plugin
Status: | Merged |
---|---|
Approved by: | Para Siva |
Approved revision: | 130 |
Merged at revision: | 126 |
Proposed branch: | lp://staging/~psivaa/jenkins-launchpad-plugin/stop-tmp-leak |
Merge into: | lp://staging/jenkins-launchpad-plugin |
Diff against target: |
89 lines (+21/-3) 3 files modified
jlp/commands/autoland.py (+7/-1) jlp/commands/getMergeProposals.py (+7/-1) jlp/commands/voteOnMergeProposal.py (+7/-1) |
To merge this branch: | bzr merge lp://staging/~psivaa/jenkins-launchpad-plugin/stop-tmp-leak |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis Ginther | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Joe Talbott (community) | Approve | ||
Review via email: mp+272144@code.staging.launchpad.net |
Commit message
Fix to wrap the launchpadlib leaking launchpadlib_cache directory.
Description of the change
To fix launchpadlib leaking launchpadlib_
The proposed one afaik appears to be the less intrusive fix to overcome the leak.
These have been patched and tested in [1]
Note:
These directories are actually created by launchpadlib [2](in the absence of the calling functions not creating directories and passing the reference). So removing them inside jlp is not so intuitive but I guess that's all we could do to fix this issue with less changes. We may actually create the directories and pass the reference to launchpadlib to use, but I think this would be outside the scope for this story.
[1]: https:/
[2]: http://
--
FAILED: Continuous integration, rev:127 jenkins. qa.ubuntu. com/job/ jenkins- launchpad- plugin- ci/40/ jenkins. qa.ubuntu. com/job/ jenkins- launchpad- plugin- trusty- amd64-ci/ 9/console jenkins. qa.ubuntu. com/job/ jenkins- launchpad- plugin- trusty- i386-ci/ 5/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/jenkins- launchpad- plugin- ci/40/rebuild
http://