Merge lp://staging/~psivaa/core-image-watcher/multi-image-tests into lp://staging/core-image-watcher
Proposed by
Para Siva
| Status: | Rejected |
|---|---|
| Rejected by: | Para Siva |
| Proposed branch: | lp://staging/~psivaa/core-image-watcher/multi-image-tests |
| Merge into: | lp://staging/core-image-watcher |
| Diff against target: |
65 lines (+25/-15) 2 files modified
core-service.conf (+13/-4) core_image_watcher/__init__.py (+12/-11) |
| To merge this branch: | bzr merge lp://staging/~psivaa/core-image-watcher/multi-image-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Larson | Needs Information | ||
|
Review via email:
|
|||
Commit message
To obtain the latest image version in different channels, image types based on the section in the config file
Description of the change
To obtain the latest image version in different channels, image types based on the section in the config file. This is done here by listing the sections under a section called 'images' and get the image specific details from each section thereby
To post a comment you must log in.
Revision history for this message
| Para Siva (psivaa) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I really hate this format for such things, but I can't offer a better alternative other than moving everything over to yaml or json (or python import like we do with constants.py). If this is not data that needs to be shared by the other pieces sharing the core-service.conf, and it's some service that isn't getting used elsewhere, our current pattern is to stick it in something like constants.py.
For this case though, that may not be an option so I'm not trying to block it, just curious if alternatives like that have been considered.