Merge lp://staging/~psivaa/core-image-tester/no-two-cores into lp://staging/core-image-tester

Proposed by Para Siva
Status: Rejected
Rejected by: Para Siva
Proposed branch: lp://staging/~psivaa/core-image-tester/no-two-cores
Merge into: lp://staging/core-image-tester
Diff against target: 12 lines (+1/-1)
1 file modified
core_image_tester/worker.py (+1/-1)
To merge this branch: bzr merge lp://staging/~psivaa/core-image-tester/no-two-cores
Reviewer Review Type Date Requested Status
Celso Providelo (community) Needs Information
Review via email: mp+255472@code.staging.launchpad.net

Commit message

The channel name coming from image publisher is 'ubuntu-core/devel-proposed'. Hence, 'core-' at the start is redundant and does not read right.

Description of the change

The channel name coming from image publisher is 'ubuntu-core/devel-proposed'. Hence, 'core-' at the start is redundant and does not read right.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Psivaa,

The 'core-' prefix is a constant useful for filtering core-image-testing containers from anything else, e.g. `swift list -p 'core-'`. If we drop the prefix we would have consider all channels ever processed, which might not be easy.

Unless I am missing something, I don't feel particularly bothered by the cachophonic path, but if we all do, we can look for another container prefix.

review: Needs Information
Revision history for this message
Para Siva (psivaa) wrote :

This wasn't a mojor issue but the results tarball was available in http://10.34.0.139:8080/v1/AUTH_07e2f90306544024af4e362c6bf56aff/core-ubuntu-core_devel-proposed-generic_amd64-363/core-ubuntu-core_devel-proposed-generic_amd64-363-results.tgz, did not sound too convenient. But if it comes for the purpose then we'll go with that.

Thanks

Unmerged revisions

29. By Para Siva

'core' at the start of the container name is redundant since channel name from publisher already has it

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches