Juju Charms Collection
snappy-proposed-image-tester package

Merge lp://staging/~psivaa/charms/trusty/snappy-proposed-image-tester/renames-subs into lp://staging/~canonical-ci-engineering/charms/trusty/snappy-proposed-image-tester/trunk

  1. Trusty Tahr (14.04)
  2. renames-subs
  3. Merge into trunk
Proposed by Para Siva
Status: Needs review
Proposed branch: lp://staging/~psivaa/charms/trusty/snappy-proposed-image-tester/renames-subs
Merge into: lp://staging/~canonical-ci-engineering/charms/trusty/snappy-proposed-image-tester/trunk
Diff against target: 113 lines (+14/-14)
6 files modified
README (+3/-3)
config.yaml (+1/-1)
hooks/actions.py (+2/-2)
hooks/services.py (+2/-2)
metadata.yaml (+3/-3)
templates/upstart.conf (+3/-3)
To merge this branch: bzr merge lp://staging/~psivaa/charms/trusty/snappy-proposed-image-tester/renames-subs
Reviewer Review Type Date Requested Status
Francis Ginther Disapprove
Celso Providelo (community) Approve
Review via email: mp+260352@code.staging.launchpad.net

Commit message

Changing names of the service and the upstart job

Description of the change

Changing names of the service and the upstart job. The upstart job is now using snappy-proposed-image-tester.py assuming the content of lp:snappy-proposed-image-tester will reflect the branch name.

To post a comment you must log in.
lp://staging/~psivaa/charms/trusty/snappy-proposed-image-tester/renames-subs updated
8. By Para Siva

Formatting

Revision history for this message
Celso Providelo (cprov) wrote :

Psivaa, thank you, it looks correct.

review: Approve
Reply
Revision history for this message
Francis Ginther (fginther) wrote :

This is identical to https://code.launchpad.net/~fginther/charms/trusty/snappy-proposed-image-tester/renames/+merge/260324 which has already landed except for some whitespace differences. I don't see any reason to also attempt to merge this. Apologies for not making the other MP obvious.

review: Disapprove
Reply

Unmerged revisions

8. By Para Siva

Formatting

7. By Para Siva

Renaming and substituting core-image-tester to snappy-proposed-image-tester

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches