Juju Charms Collection
jenkaas package

Merge lp://staging/~psivaa/charms/trusty/jenkaas/install-plugins into lp://staging/~canonical-ci-engineering/charms/trusty/jenkaas/trunk

  1. Trusty Tahr (14.04)
  2. install-plugins
  3. Merge into trunk
Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 13
Merged at revision: 4
Proposed branch: lp://staging/~psivaa/charms/trusty/jenkaas/install-plugins
Merge into: lp://staging/~canonical-ci-engineering/charms/trusty/jenkaas/trunk
Prerequisite: lp://staging/~psivaa/charms/trusty/jenkaas/install-jenkins
Diff against target: 59 lines (+19/-9)
2 files modified
hooks/actions.py (+18/-8)
hooks/services.py (+1/-1)
To merge this branch: bzr merge lp://staging/~psivaa/charms/trusty/jenkaas/install-plugins
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Francis Ginther Approve
Review via email: mp+261841@code.staging.launchpad.net

Commit message

Installing jenkins plugins copied to charm/files/plugins by the spec

Description of the change

Installing jenkins plugins copied to charm/files/plugins by the spec

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

I agree that we'll need to install the plugins by passing them along inside the charm payload. But I think we're better off actually coping them to /var/lib/jenkins/plugins and making sure they are owned by "jenkins:jenkins".

review: Needs Fixing
lp://staging/~psivaa/charms/trusty/jenkaas/install-plugins updated
7. By Para Siva

Merging install jenkins

8. By Para Siva

pyflakes and pep8

9. By Para Siva

Copying instead of symlinking

10. By Para Siva

pep8 and pyflakes

11. By Para Siva

Set the ownership to the right plugins

Revision history for this message
Para Siva (psivaa) wrote :

Thanks Francis for the review and the informal review :). I think I've addressed your concerns. Would appreciate a re-review.

lp://staging/~psivaa/charms/trusty/jenkaas/install-plugins updated
12. By Para Siva

Remove config file setup

13. By Para Siva

pyflakes

Revision history for this message
Francis Ginther (fginther) wrote :

Looks good.

review: Approve
Revision history for this message
Joe Talbott (joetalbott) wrote :

This looks good to me. One minor comment inline regarding os.path.exists()/mkdir() combination.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches