Merge lp://staging/~psivaa/canonical-identity-provider/username-must-in-webui-reg into lp://staging/canonical-identity-provider/release
Proposed by
Para Siva
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~psivaa/canonical-identity-provider/username-must-in-webui-reg |
| Merge into: | lp://staging/canonical-identity-provider/release |
| Diff against target: |
631 lines (+411/-33) 10 files modified
src/api/v10/tests/test_handlers.py (+21/-0) src/api/v20/handlers.py (+5/-1) src/api/v20/registration.py (+17/-10) src/api/v20/tests/test_handlers.py (+89/-0) src/api/v20/tests/test_registration.py (+90/-0) src/identityprovider/forms.py (+23/-0) src/identityprovider/tests/test_forms.py (+68/-2) src/webui/templates/registration/_create_account_form.html (+12/-1) src/webui/tests/test_views_registration.py (+81/-17) src/webui/views/registration.py (+5/-2) |
| To merge this branch: | bzr merge lp://staging/~psivaa/canonical-identity-provider/username-must-in-webui-reg |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu One hackers | Pending | ||
|
Review via email:
|
|||
Commit message
Make Username in webui registration mandatory
Description of the change
This includes adding an optional 'username' arg to the V2 register API, which makes it possible to add 'username' in 'new-account' API requests, whilst keeping the existing behaviour of the API unchanged with or without USERNAME_UI gargole flag set.
Setting the 'username' means that a placeholder LP account is created and this is a change in the background for the register API, but not providing a username in the API request, does not need to create the LP placeholder account, hence no compatibility break.
Tests have also been added to ensure this.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
