Merge lp://staging/~psivaa/canonical-identity-provider/better-userreg-ui into lp://staging/canonical-identity-provider/release
Proposed by
Para Siva
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Para Siva | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merge reported by: | Ubuntu One Auto Pilot | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~psivaa/canonical-identity-provider/better-userreg-ui | ||||
| Merge into: | lp://staging/canonical-identity-provider/release | ||||
| Diff against target: |
196 lines (+19/-41) 8 files modified
src/api/v20/tests/test_registration.py (+4/-18) src/identityprovider/fields.py (+1/-1) src/identityprovider/forms.py (+3/-3) src/identityprovider/tests/test_fields.py (+1/-1) src/identityprovider/tests/test_forms.py (+2/-7) src/webui/templates/registration/_create_account_form.html (+2/-2) src/webui/tests/test_views_account.py (+1/-1) src/webui/tests/test_views_registration.py (+5/-8) |
||||
| To merge this branch: | bzr merge lp://staging/~psivaa/canonical-identity-provider/better-userreg-ui | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix bug-1626102
Description of the change
Just want to push the changes that I already made for this bug:
This does the following:
1. Replace the 'Your name' placeholder as 'Fistname Lastname'
2. Error message to say 'Usernames must be at least two...' instead of 'Names must be at least two..'
3. Change the help text to 'Please tell us your full name, username and password' (instead of 'Please tell us your name, username and passowrd')
To post a comment you must log in.
Revision history for this message
| Para Siva (psivaa) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good!
Two things to change and then just global approve for landing:
1- Instead of "Firstname Lastname" as placeholder please use "Your full name"
(because in many languages the last name comes first, or something there isn't even a first/last name distinction)
2- Please define a constant for the form error so we don't duplicate the error message in all tests.
Thanks!