Auto Package Testing

Merge lp://staging/~psivaa/auto-package-testing/nova-adt-jenkins into lp://staging/~canonical-ci-engineering/auto-package-testing/adt-nova-support

nova-adt-jenkins
Merge into adt-nova-support

Proposed by Para Siva on 2015-03-18

Status:	Merged
Approved by:	Francis Ginther on 2015-03-19
Approved revision:	405
Merged at revision:	398
Proposed branch:	lp://staging/~psivaa/auto-package-testing/nova-adt-jenkins
Merge into:	lp://staging/~canonical-ci-engineering/auto-package-testing/adt-nova-support
Diff against target:	308 lines (+264/-0) 4 files modified jenkins/adt-nova.conf (+3/-0) jenkins/adtjob.py (+5/-0) jenkins/jenkins_config_nova.xml.tmpl (+175/-0) jenkins/run-nova-autopkgtest (+81/-0)
To merge this branch:	bzr merge lp://staging/~psivaa/auto-package-testing/nova-adt-jenkins
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Francis Ginther		Approve on 2015-03-19
Celso Providelo (community)	2015-03-18	Needs Fixing on 2015-03-18
Paul Larson		Approve on 2015-03-18
Review via email: mp+253361@code.staging.launchpad.net

Commit message

auto-package-testing changes to post a request to adt-cloud-service

Description of the change

auto-package-testing changes to post a request to adt-cloud-service. Issuing a request to the cloud-service, and downloading the result.tgz file is done on this MP. The actual files in the result tarball are different to the standard adt result files and the files in the tarball needs to be converted to be compatible with the adt type of files (e.g. .error, .result etc) I'd prefer to do that as another MP.

lp://staging/~psivaa/auto-package-testing/nova-adt-jenkins updated on 2015-03-18

400. By Para Siva on 2015-03-18: Fixes after successful request postings

Revision history for this message

Celso Providelo (cprov) wrote on 2015-03-18:

Psivaa,

I haven't looked at deep, but the test request to adt-cloud-service has to be a POST, not a GET (curl -X POST).

review: Needs Fixing

lp://staging/~psivaa/auto-package-testing/nova-adt-jenkins updated on 2015-03-18

401. By Para Siva on 2015-03-18: Wget the result file from public swift and rsync the results file to tachash

Revision history for this message

Para Siva (psivaa) wrote on 2015-03-18:

Cprov,
As explained in irc by Thomi, POST is not needed when --data is not needed. Could you take another look when you've some time please?

I've also used wget to download the result file and the result processing is now similar to what's being done in boottest and adt.
Thanks

Revision history for this message

Paul Larson (pwlars) wrote on 2015-03-18:

Some kind of example adt-nova.conf seems like it would be a good thing to add here. Otherwise this all looks ok to me, though I haven't managed to put together all the pieces to test it live.

review: Approve

Revision history for this message

Celso Providelo (cprov) on 2015-03-18:

review: Needs Fixing

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2015-03-19:

A few comments...

Revision history for this message

Francis Ginther (fginther) wrote on 2015-03-19:

Thanks for working on this.

Added some comments for run-nova-autopkgtest. You were right that the results and error files could not be created without a little bit more help. The missing piece should just be the adt-run return code which is being added (see the inline comment). Everything else to generate those files should already be part of the results dir.

Also, how was the jenkins job template generated? I did a diff on this compared to jenkins_config.xml.tmpl and noticed some unexpected differences. But if this was generated from the prototype jenkins config.xml file, then that's somewhat expected. This isn't necessarily something that needs to be addressed, just curious.

review: Needs Fixing

Revision history for this message

Francis Ginther (fginther) wrote on 2015-03-19:

Updated my comment on the timeout. It's not that big of a deal how it's implemented, just as long as we have at least a timeout on the jenkins job as a last resort.

lp://staging/~psivaa/auto-package-testing/nova-adt-jenkins updated on 2015-03-19