Smart Package Manager

Merge lp://staging/~proyvind/smart/pycurl into lp://staging/smart

Proposed by Per Øyvind Karlsen on 2010-03-06

Status:	Rejected
Rejected by:	Anders F Björklund on 2011-09-23
Proposed branch:	lp://staging/~proyvind/smart/pycurl
Merge into:	lp://staging/smart
Diff against target:	184 lines (+45/-54) 2 files modified smart/fetcher.py (+38/-53) tests/fetcher.py (+7/-1)
To merge this branch:	bzr merge lp://staging/~proyvind/smart/pycurl
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Smart Package Manager Team		2010-03-06	Pending
Review via email: mp+20830@code.staging.launchpad.net

contains various fixes to make pycurl usable with smart (it's currently utterly useless and breaks smart hard in several ways without these..)

Some of the changes might not be the most optimal wrt. nice code and all, but at least it brings awareness on what's broken and how to fix :)

Revision history for this message

Anders F Björklund (afb) wrote on 2010-03-06:

Just a quick note that it breaks differently on different versions of pycurl.

For instance whether or not it has multi-threading, and some other variables.

Revision history for this message

Anders F Björklund (afb) wrote on 2010-03-07:

This needs more tests. Maybe not for the "sleep", but for all the other changes.

And when the tests break, like with r948, fix the code and not the tests (r949).

950. By Per Øyvind Karlsen on 2010-03-06: fix slow download (always < ~100K/sec} with pycurl caused by sleep()
949. By Per Øyvind Karlsen on 2010-03-06: fix so that test_404_handling pass with different error message from pycurl
948. By Per Øyvind Karlsen on 2010-03-06: make curl fail on error <http://tracker.labix.org/issue310>
947. By Per Øyvind Karlsen on 2010-03-06: fix curl 'double free' (patch from http://lists.labix.org/pipermail/smart-labix.org/2007-October/003157.html)