Merge lp://staging/~prakhar126/postorius/adding_dropdown_option into lp://staging/postorius

Proposed by pjoshi
Status: Merged
Merged at revision: 234
Proposed branch: lp://staging/~prakhar126/postorius/adding_dropdown_option
Merge into: lp://staging/postorius
Diff against target: 56 lines (+33/-1)
2 files modified
src/postorius/forms.py (+10/-1)
src/postorius/tests/test_forms.py (+23/-0)
To merge this branch: bzr merge lp://staging/~prakhar126/postorius/adding_dropdown_option
Reviewer Review Type Date Requested Status
Terri Needs Fixing
Review via email: mp+252878@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Terri (terriko) wrote :

I'm finding some errors in the tests here (missing commas, for example). I'll see if they're things I can fix relatively quickly.

review: Needs Fixing
Revision history for this message
Terri (terriko) wrote :

Here's the fixed code. There were a lot of syntax errors here. In future, please actually run the tests before you submit a merge proposal!

class ListNewTest(unittest.TestCase):

    def test_form_fields_list(self):
        form = ListNew({
            'listname': 'xyz',
            'mail_host': 'mailman.most-desirable.org',
            'list_owner': '<email address hidden>',
            'advertise': 'abcd',
            'description': 'The Most Desirable organization',
        })
        self.assertTrue(form.is_valid)

    def test_form_fields_list_invalid(self):
        form = ListNew({
             'listname': 'xy#z',
             'mail_host': 'mailman.most-desirable.org',
             'list_owner': 'mailman.most-desirable.org',
             'advertise': 'abcd',
             'description': 'The Most Desirable organization',
        })
        self.assertFalse(form.is_valid())

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches