Daisy

Merge lp://staging/~pitti/daisy/fixes into lp://staging/daisy

  1. fixes
  2. Merge into trunk
Proposed by Martin Pitt
Status: Merged
Merged at revision: 694
Proposed branch: lp://staging/~pitti/daisy/fixes
Merge into: lp://staging/daisy
Diff against target: 24 lines (+3/-4)
1 file modified
daisy/retracer.py (+3/-4)
To merge this branch: bzr merge lp://staging/~pitti/daisy/fixes
Reviewer Review Type Date Requested Status
Brian Murray (community) Approve
Review via email: mp+289092@code.staging.launchpad.net

Description of the change

Fix bug 1546602 as a finger exercise :-)

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

The msg as seen in the log file already looks like:

2016-03-15 19:57:06,050:16558:140616891983680:INFO:root:Running with sandbox_dir /srv/daisy.staging.ubuntu.com/devel/cache.

Some of the information your are adding seems redundant or excessive.

u'GNU gdb (Ubuntu 7.11-0ubuntu1) 7.11'

Maybe we could just add the package version to msg?

Revision history for this message
Martin Pitt (pitti) wrote :

It now looks like this:

2016-03-15 20:19:08,948:23761:139661109266240:INFO:root:Running with sandbox_dir /srv/daisy.staging.ubuntu.com/devel/cache, gdb 7.10-1ubuntu3~14.04.1.

I switched to dpkg-query as I'm not sure how predictable that first line is over different Ubuntu series.

Revision history for this message
Brian Murray (brian-murray) wrote :

Looks great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: