Merge lp://staging/~pimvullers/beat-box/fix-983560 into lp://staging/beat-box

Proposed by Pim Vullers
Status: Rejected
Rejected by: Scott Ringwelski
Proposed branch: lp://staging/~pimvullers/beat-box/fix-983560
Merge into: lp://staging/beat-box
Diff against target: 68 lines (+10/-10)
2 files modified
core/Settings.vala (+5/-5)
schemas/org.pantheon.beatbox.gschema.xml (+5/-5)
To merge this branch: bzr merge lp://staging/~pimvullers/beat-box/fix-983560
Reviewer Review Type Date Requested Status
Victor Martinez (community) Needs Fixing
Review via email: mp+106385@code.staging.launchpad.net

Description of the change

This branch fixes bug #983560 by renaming apps to org.pantheon or org/pantheon.

To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

I don't know why it was decided to use org.pantheon.* instead of org.elementary.* for all the applications, but anyway, "apps" is deprecated and a different domain should be used instead. I would suggest using net.launchpad.beatbox, since BeatBox is no longer an elementary app.

review: Needs Fixing
Revision history for this message
Pim Vullers (pimvullers) wrote :

Ok, I'll fix it when I've got some time for it.

Revision history for this message
Scott Ringwelski (sgringwe) wrote :

This is fixed in a different branch now.

Unmerged revisions

587. By Pim Vullers

Fixed bug #983560

586. By Launchpad Translations on behalf of beatbox-team

Launchpad automatic translations update.

585. By Launchpad Translations on behalf of beatbox-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches