Merge into experimental : honour_auto

Status:	Merged
Merged at revision:	915
Proposed branch:	lp://staging/~pieterleclerc-deactivatedaccount/wicd/honour_auto_reconnect
Merge into:	lp://staging/wicd/1.6
Diff against target:	15 lines (+0/-5) 1 file modified wicd/wicd-daemon.py (+0/-5)
To merge this branch:	bzr merge lp://staging/~pieterleclerc-deactivatedaccount/wicd/honour_auto_reconnect
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Pieter Leclerc (community)			Approve on 2014-12-11
Review via email: mp+240683@code.staging.launchpad.net

Commit message

Automatic reconnect: honour the automatic reconnect configuration, even if the GUI interface is open

When a user actives "automatic reconnnect" and then tries this out, he will be staring at the GUI interface, waiting for a reconnect.
But wicd-daemon refuses to reconnect when the GUI interface is open, and fails to reports this to the GUI user.
Hence users assume that this feature does not work properly (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582567).

This commit fixes that by doing a reconnect, no matter whether the GUI is open or not, thus taking the path of "least surprise".
The original rationale for not reconnecting when the GUI is open was never stated in the comments, nor in the commit message.

Description of the change

Automatic reconnect: honour the automatic reconnect configuration, even if the GUI interface is open

When a user actives "automatic reconnnect" and then tries this out, he will be staring at the GUI interface, waiting for a reconnect.
But wicd-daemon refuses to reconnect when the GUI interface is open, and fails to reports this to the GUI user.
Hence users assume that this feature does not work properly (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582567).

This commit fixes that by doing a reconnect, no matter whether the GUI is open or not, thus taking the path of "least surprise".
The original rationale for not reconnecting when the GUI is open was never stated in the comments, nor in the commit message.

Revision history for this message

Pieter Leclerc (pieterleclerc-deactivatedaccount) wrote on 2014-11-14:

#

Dear wicd developers,

I posted this merge request
<https://code.launchpad.net/~tomvanbraeckel/wicd/honour_auto_reconnect/+merge/240683>
for a bugfix
<https://code.launchpad.net/~tomvanbraeckel/wicd/honour_auto_reconnect>
some time ago, but I didn't get any feedback...

It's a very small fix. Could you please take a look and merge if
possible...?

Thanks,

Tom Van Braeckel
GSM: 0032 (0) 486 63 58 04

Revision history for this message

Pieter Leclerc (pieterleclerc-deactivatedaccount) wrote on 2014-12-09:

#

Reminder...

Met vriendelijke groeten, Salutations sincères, Kind regards,

Tom Van Braeckel
GSM: 0032 (0) 486 63 58 04

On Fri, Nov 14, 2014 at 11:38 AM, Tom Van Braeckel <<email address hidden>
> wrote:

> Dear wicd developers,
>
> I posted this merge request
> <https://code.launchpad.net/~tomvanbraeckel/wicd/honour_auto_reconnect/+merge/240683>
> for a bugfix
> <https://code.launchpad.net/~tomvanbraeckel/wicd/honour_auto_reconnect>
> some time ago, but I didn't get any feedback...
>
> It's a very small fix. Could you please take a look and merge if
> possible...?
>
> Thanks,
>
> Tom Van Braeckel
> GSM: 0032 (0) 486 63 58 04
>
>

Revision history for this message

Weedy (weedy2887) wrote on 2014-12-09:

#

Wicd is basically dead.

With NM being modularised so well now I'm not even sure the world needs
wicd anymore.

Revision history for this message

Pieter Leclerc (pieterleclerc-deactivatedaccount) wrote on 2014-12-10:

#

> Wicd is basically dead.
>
> With NM being modularised so well now I'm not even sure the world needs
> wicd anymore.

Thanks for the reply!

I understand that some people are not interested in maintaining WICD anymore and that they prefer NetworkManager. That's fine, but I am not one of those people :-)

Can you give me the necessary clearance so that I can do the merge myself, please?

Revision history for this message

Weedy (weedy2887) wrote on 2014-12-11:

#

On Dec 10, 2014 2:45 AM, "Tom Van Braeckel" <email address hidden>
wrote:
>
> > Wicd is basically dead.
> >
> > With NM being modularised so well now I'm not even sure the world needs
> > wicd anymore.
>
> Thanks for the reply!
>
> I understand that some people are not interested in maintaining WICD
anymore and that they prefer NetworkManager. That's fine, but I am not one
of those people :-)
>
> Can you give me the necessary clearance so that I can do the merge
myself, please?

Your best option is trying to contact the Debian maintainer. He was the
last active Dev I saw.

You can always commit your changes on something like github, you could
become the goto fork if you keep it going.

Revision history for this message

Pieter Leclerc (pieterleclerc-deactivatedaccount) on 2014-12-11:

#

review: Approve

wicd

Merge lp://staging/~pieterleclerc-deactivatedaccount/wicd/honour_auto_reconnect into lp://staging/wicd/1.6

Commit message

Description of the change

Preview Diff

Subscribers