Merge lp://staging/~pieq/checkbox/fix-1609325-longer-SID into lp://staging/checkbox
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Maciej Kisielewski | ||||
| Approved revision: | 4461 | ||||
| Merged at revision: | 4458 | ||||
| Proposed branch: | lp://staging/~pieq/checkbox/fix-1609325-longer-SID | ||||
| Merge into: | lp://staging/checkbox | ||||
| Diff against target: |
2149 lines (+402/-404) 9 files modified
checkbox-ng/checkbox_ng/certification.py (+2/-2) checkbox-ng/checkbox_ng/commands/newcli.py (+2/-2) checkbox-ng/checkbox_ng/commands/submit.py (+1/-1) checkbox-ng/checkbox_ng/test_certification.py (+5/-5) checkbox-ng/po/checkbox-ng.pot (+69/-121) plainbox/plainbox/impl/transport.py (+3/-3) plainbox/po/POTFILES.in (+0/-1) plainbox/po/plainbox.pot (+318/-267) tools/canonical-hw-collection/canonical-hw-collection (+2/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~pieq/checkbox/fix-1609325-longer-SID | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski (community) | Approve | ||
| Paul Larson | Approve | ||
|
Review via email:
|
|||
Description of the change
Allow Secure IDs of more than 18 chars to be used when submitting to Certification
HEXR now uses Secure IDs (SID) made of 22 alphanumeric characters. However,
most scripts used in Checkbox/Plainbox were expecting 15 or 18 characters.
To test, you can use different ways of submitting:
1. run a launcher pointing to certification-
The launcher looks like this:
-------
#!/usr/bin/env checkbox-cli
[launcher]
launcher_version = 1
app_id = 2016.com.
stock_reports = text, submission_files, certification-
[ui]
type = interactive
[transport:c3]
secure_id = mXat4w43eMNP3Y2
-------
(of course you have to adjust the secure_id to your needs)
2. run the 'checkbox submit' tool (see --help for more info)
3. use the 'canonical-
| Pierre Equoy (pieq) wrote | # |
regexp confirmed for 15+, looks good. +1