Merge lp://staging/~philip.scott/wingpanel-indicator-power/UpowerFix into lp://staging/~wingpanel-devs/wingpanel-indicator-power/trunk

Proposed by Felipe Escoto
Status: Merged
Approved by: Cody Garver
Approved revision: 137
Merged at revision: 130
Proposed branch: lp://staging/~philip.scott/wingpanel-indicator-power/UpowerFix
Merge into: lp://staging/~wingpanel-devs/wingpanel-indicator-power/trunk
Diff against target: 271 lines (+75/-62)
6 files modified
src/Services/DBusInterfaces/Device.vala (+27/-2)
src/Services/DBusInterfaces/Properties.vala (+2/-1)
src/Services/DBusInterfaces/UPower.vala (+4/-6)
src/Services/Device.vala (+33/-40)
src/Services/DeviceManager.vala (+7/-11)
src/Utils.vala (+2/-2)
To merge this branch: bzr merge lp://staging/~philip.scott/wingpanel-indicator-power/UpowerFix
Reviewer Review Type Date Requested Status
Marcus Wichelmann (community) code Needs Fixing
Review via email: mp+286804@code.staging.launchpad.net

Commit message

Updated to Upower's new interface

Description of the change

Latest Upower update broke the indicator, this branch fixes these issues and makes it able to show up again

To post a comment you must log in.
130. By Felipe Escoto

reverted image change

131. By Felipe Escoto

String to ObjectPaths and fixed propertieschanded sigals

132. By Felipe Escoto

Force refresh on properties update

133. By Felipe Escoto

Giving up on Upower.... one last try!

134. By Felipe Escoto

one more try

135. By Felipe Escoto

Changed method of getting dbus properties

136. By Felipe Escoto

refresh before update

Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

I've added two comments :P

review: Needs Fixing (code)
137. By Felipe Escoto

Code style fixes, and unused params removal

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches