Switchboard Display Plug

Merge lp://staging/~philip.scott/switchboard-plug-display/snaps into lp://staging/~elementary-apps/switchboard-plug-display/trunk

  1. snaps
  2. Merge into trunk
Proposed by Felipe Escoto
Status: Merged
Approved by: Adam Bieńkowski
Approved revision: 173
Merged at revision: 163
Proposed branch: lp://staging/~philip.scott/switchboard-plug-display/snaps
Merge into: lp://staging/~elementary-apps/switchboard-plug-display/trunk
Diff against target: 437 lines (+246/-36)
3 files modified
src/DisplayWidget.vala (+93/-35)
src/DisplaysView.vala (+152/-1)
src/MirrorDisplay.vala (+1/-0)
To merge this branch: bzr merge lp://staging/~philip.scott/switchboard-plug-display/snaps
Reviewer Review Type Date Requested Status
Adam Bieńkowski (community) code Approve
Cassidy James Blaede ux Approve
Review via email: mp+302214@code.staging.launchpad.net

Commit message

- Sanitize extra space
- monitor snapping
- show vertical monitors as vertical
- Auto select a resolution when enabling a display

Description of the change

Fixes a whole bunch of stuff!

To post a comment you must log in.
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

This looks mostly great from a UX perspective and moves us much farther from broken and closer to perfect. ;)

One thing I found was that changing the rotation (i.e. to Clockwise) and then back to None does not properly re-size the display when going back to None.

review: Needs Fixing (ux)
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Rotation does appear to be working as expected now. I think my one last gripe is that sometimes disabled displays are corner-snapping to the top-right of my enabled display. This appears only to happen when the enabled display is the "blue" one and the disabled is the "red" one (however that's being numbered under-the-hood). When "red" is enabled and "blue" is disabled, it works as expected.

Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Made a few diff comments, not tested though. Some code style issues, nothing really important, other than that it's a great job!

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Disabled displays appear to have been fixed as well. Giving this a thumbs up UX-wise.

review: Approve (ux)
lp://staging/~philip.scott/switchboard-plug-display/snaps updated
172. By Felipe Escoto

Comapare structs, not strings

173. By Felipe Escoto

use constant

Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Looks okay now! Thanks.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: