Merge lp://staging/~philip.scott/granite/deprecate-deprecated into lp://staging/~elementary-pantheon/granite/granite

Proposed by Felipe Escoto
Status: Merged
Approved by: Danielle Foré
Approved revision: 946
Merged at revision: 946
Proposed branch: lp://staging/~philip.scott/granite/deprecate-deprecated
Merge into: lp://staging/~elementary-pantheon/granite/granite
Diff against target: 950 lines (+124/-124)
20 files modified
lib/Application.vala (+5/-5)
lib/Services/Contractor.vala (+2/-2)
lib/Widgets/AppMenu.vala (+15/-15)
lib/Widgets/CellRendererBadge.vala (+1/-1)
lib/Widgets/CellRendererExpander.vala (+2/-2)
lib/Widgets/CollapsiblePaned.vala (+2/-2)
lib/Widgets/ContractorMenu.vala (+13/-13)
lib/Widgets/ContractorView.vala (+28/-28)
lib/Widgets/DecoratedWindow.vala (+6/-6)
lib/Widgets/DynamicNotebook.vala (+3/-3)
lib/Widgets/Entries.vala (+6/-6)
lib/Widgets/LightWindow.vala (+2/-2)
lib/Widgets/PopOver.vala (+15/-15)
lib/Widgets/SidebarPaned.vala (+1/-1)
lib/Widgets/SourceList.vala (+4/-4)
lib/Widgets/StaticNotebook.vala (+3/-3)
lib/Widgets/StatusBar.vala (+9/-9)
lib/Widgets/ThinPaned.vala (+1/-1)
lib/Widgets/ToolButtonWithMenu.vala (+5/-5)
lib/Widgets/WrapLabel.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~philip.scott/granite/deprecate-deprecated
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+296890@code.staging.launchpad.net

Commit message

Replace Deprecate with [Version (deprecated = true]

Description of the change

[Deprecate] is now deprecated, so we need to deprecate Deprecated from Granite so that Deprecated won't give deprecated warnings

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Seems to compile fine here

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

This of course quietly bumps the valac requirement to sustain the deprecation warnings.
Using VALA_0_32 conditionals would have been better

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches