Merge lp://staging/~phablet-team/ubuntu-settings-components/set-albumart-size into lp://staging/ubuntu-settings-components
Proposed by
Jim Hodapp
| Status: | Merged |
|---|---|
| Approved by: | Andrea Cimitan |
| Approved revision: | 148 |
| Merged at revision: | 147 |
| Proposed branch: | lp://staging/~phablet-team/ubuntu-settings-components/set-albumart-size |
| Merge into: | lp://staging/ubuntu-settings-components |
| Diff against target: |
22 lines (+6/-0) 1 file modified
plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml (+6/-0) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/ubuntu-settings-components/set-albumart-size |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Andrea Cimitan (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit message
Make sure a size is specified for the albumArtImage for indicator-sound or else the albumart lookup via thumbnailer will fail and the albumArtImage will not render.
Description of the change
Make sure a size is specified for the albumArtImage for indicator-sound or else the albumart lookup via thumbnailer will fail and the albumArtImage will not render.
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Andrea Cimitan (cimi) | # |
review:
Approve
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:147
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/