Merge into trunk : split-multipart-messages : Code : telephony-service

Status:	Superseded
Proposed branch:	lp://staging/~phablet-team/telephony-service/split-multipart-messages
Merge into:	lp://staging/telephony-service
Prerequisite:	lp://staging/~phablet-team/telephony-service/destroy_chatrooms
Diff against target:	88 lines (+43/-4) 2 files modified handler/messagesendingjob.cpp (+42/-4) handler/messagesendingjob.h (+1/-0)
To merge this branch:	bzr merge lp://staging/~phablet-team/telephony-service/split-multipart-messages
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2016-06-13	Approve on 2016-06-14
system-apps-ci-bot	continuous-integration	2016-06-13	Needs Fixing on 2016-06-14
PS Jenkins bot	continuous-integration	2016-06-13	Pending
Review via email: mp+297187@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-06-13.

This proposal has been superseded by a proposal from 2016-10-13.

Commit message

split multipart messages into multiple messages on some protocols

Description of the change

split multipart messages into multiple messages on some protocols

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-06-13: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/11/rebuild

PASSED: Continuous integration, rev:1200
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/11/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/546
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/58
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/546
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/534
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/534
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/530
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/530/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/530
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/530/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/530
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/530/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/530
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/530/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/530
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/530/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/530
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/530/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/11/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2016-06-13:

#

Code looks good, but can you just add a comment saying that in some protocolos sending multiple attachments don't work, and that's why we have to split the message?

review: Needs Fixing

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-06-13:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/12/rebuild

PASSED: Continuous integration, rev:1201
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/12/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/547
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/59
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/547
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/535
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/535
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/531
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/531/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/531
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/531/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/531
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/531/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/531
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/531/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/531
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/531/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/531
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/531/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/12/rebuild

review: Approve (continuous-integration)

lp://staging/~phablet-team/telephony-service/split-multipart-messages updated on 2016-06-14

1202. By Tiago Salem Herrmann on 2016-06-14: add comment

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-06-14:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/16/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2016-06-14:

#

Looks good!

review: Approve

lp://staging/~phablet-team/telephony-service/split-multipart-messages updated on 2016-10-06

1203. By Gustavo Pichorim Boiko on 2016-06-15: merge parent
1204. By Tiago Salem Herrmann on 2016-06-27: merge parent branch
1205. By Tiago Salem Herrmann on 2016-06-27: use accountId after fallback to build messages
1206. By Tiago Salem Herrmann on 2016-06-27: merge parent branch
1207. By Tiago Salem Herrmann on 2016-06-27: merge parent branch
1208. By Gustavo Pichorim Boiko on 2016-07-06: Merge parent
1209. By Tiago Salem Herrmann on 2016-07-07: merge parent branch
1210. By Tiago Salem Herrmann on 2016-07-08: merge parent branch
1211. By Tiago Salem Herrmann on 2016-07-08: merge parent branch
1212. By Tiago Salem Herrmann on 2016-07-11: merge parent branch
1213. By Tiago Salem Herrmann on 2016-07-11: merge parent branch
1214. By Tiago Salem Herrmann on 2016-07-11: merge parent branch
1215. By Gustavo Pichorim Boiko on 2016-07-13: merge parent
1216. By Tiago Salem Herrmann on 2016-08-05: merge parent branch
1217. By Tiago Salem Herrmann on 2016-08-05: merge parent branch
1218. By Tiago Salem Herrmann on 2016-08-11: merge parent branch
1219. By Tiago Salem Herrmann on 2016-08-12: merge parent branch
1220. By Tiago Salem Herrmann on 2016-08-12: merge parent branch
1221. By Tiago Salem Herrmann on 2016-08-16: merge parent branch
1222. By Tiago Salem Herrmann on 2016-10-06: merge parent branch

telephony-service

Merge lp://staging/~phablet-team/telephony-service/split-multipart-messages into lp://staging/telephony-service

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers