telephony-service

Merge lp://staging/~phablet-team/telephony-service/request-channel-after-relogin into lp://staging/telephony-service/staging

  1. request-channel-after-relogin
  2. Merge into staging
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1231
Merged at revision: 1224
Proposed branch: lp://staging/~phablet-team/telephony-service/request-channel-after-relogin
Merge into: lp://staging/telephony-service/staging
Prerequisite: lp://staging/~phablet-team/telephony-service/roles-client-interface
Diff against target: 54 lines (+26/-0)
2 files modified
libtelephonyservice/chatentry.cpp (+25/-0)
libtelephonyservice/chatentry.h (+1/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/telephony-service/request-channel-after-relogin
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Tiago Salem Herrmann Pending
system-apps-ci-bot continuous-integration Pending
Review via email: mp+308449@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-10-06.

Commit message

Creates the channel if in a conversation or conversation details pages when reconnection

Description of the change

Creates the channel if in a conversation or conversation details pages when reconnection

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:1230
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/77/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1766/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1766
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1611/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1611/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/77/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:1231
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/78/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1782/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1782
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1627/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1627/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/78/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: