telephony-service

Merge lp://staging/~phablet-team/telephony-service/more_protocols_properties into lp://staging/telephony-service/staging

  1. more_protocols_properties
  2. Merge into staging
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1254
Merged at revision: 1241
Proposed branch: lp://staging/~phablet-team/telephony-service/more_protocols_properties
Merge into: lp://staging/telephony-service/staging
Prerequisite: lp://staging/~phablet-team/telephony-service/sip-account
Diff against target: 448 lines (+196/-9)
15 files modified
handler/Handler.xml (+9/-2)
handler/handlerdbus.cpp (+5/-0)
handler/handlerdbus.h (+1/-0)
handler/texthandler.cpp (+12/-0)
handler/texthandler.h (+1/-0)
libtelephonyservice/chatmanager.cpp (+6/-0)
libtelephonyservice/chatmanager.h (+1/-0)
libtelephonyservice/dbustypes.h (+6/-0)
libtelephonyservice/protocol.cpp (+74/-3)
libtelephonyservice/protocol.h (+36/-0)
libtelephonyservice/protocolmanager.cpp (+2/-2)
protocols/README.protocols (+7/-0)
protocols/ofono.protocol (+4/-0)
tests/libtelephonyservice/ProtocolTest.cpp (+26/-2)
tests/libtelephonyservice/testProtocols/foo.protocol (+6/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/telephony-service/more_protocols_properties
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+314169@code.staging.launchpad.net

Commit message

- Add more properties to the .protocol files
- Expose method on dbus to leave all rooms from a certain account.

Description of the change

Add more properties to the .protocol files

To post a comment you must log in.
lp://staging/~phablet-team/telephony-service/more_protocols_properties updated
1241. By Tiago Salem Herrmann

fix dbus signature

1242. By Tiago Salem Herrmann

Add option to disable attachments

1243. By Tiago Salem Herrmann

add new properties to ofono.protocol

1244. By Tiago Salem Herrmann

Add EnableRejoin property

1245. By Tiago Salem Herrmann

this is going to be added in another commit

1246. By Tiago Salem Herrmann

Add EnableTabCompletion property

1247. By Tiago Salem Herrmann

merge parent branch

1248. By Tiago Salem Herrmann

Add property: LeaveRoomsOnClose

1249. By Gustavo Pichorim Boiko

Merge parent

1250. By Gustavo Pichorim Boiko

Merge parent branch

1251. By Tiago Salem Herrmann

merge parent branch

1252. By Tiago Salem Herrmann

Add EnableChatStates property

1253. By Tiago Salem Herrmann

merge parent branch

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

In the future we can replace some of those protocol flags by checking the capabilities on the Telepathy level, but for now this is ok.

A couple remarks:
- Can you please document all those new properties in protocols/README.protocols?
- Could you update the description and the commit message to mention that you are also implementing support in telephony-service-handler for leaving rooms?

review: Needs Fixing
lp://staging/~phablet-team/telephony-service/more_protocols_properties updated
1254. By Tiago Salem Herrmann

add descriptions to README

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

done.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: