Merge lp://staging/~phablet-team/telephony-service/fix_protocol_filters into lp://staging/telephony-service/staging
Proposed by
Tiago Salem Herrmann
| Status: | Merged |
|---|---|
| Merged at revision: | 1242 |
| Proposed branch: | lp://staging/~phablet-team/telephony-service/fix_protocol_filters |
| Merge into: | lp://staging/telephony-service/staging |
| Prerequisite: | lp://staging/~phablet-team/telephony-service/more_protocols_properties |
| Diff against target: |
39 lines (+6/-1) 3 files modified
TODO (+2/-0) libtelephonyservice/accountlist.cpp (+1/-1) libtelephonyservice/telepathyhelper.cpp (+3/-0) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/telephony-service/fix_protocol_filters |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Pichorim Boiko (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix protocol filters
Description of the change
Fix protocol filters
To post a comment you must log in.
Revision history for this message
| Tiago Salem Herrmann (tiagosh) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
That's a good catch! Code looks good.
I think this problem is worth having an automated test, but it doesn't have to be written in this merge proposal.
Can you please add an entry in the TODO file saying that a test is required to cover this case?