Merge lp://staging/~phablet-team/telephony-service/connect-disconnect-accounts into lp://staging/telephony-service/staging

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1247
Merged at revision: 1251
Proposed branch: lp://staging/~phablet-team/telephony-service/connect-disconnect-accounts
Merge into: lp://staging/telephony-service/staging
Prerequisite: lp://staging/~phablet-team/telephony-service/online-account-match
Diff against target: 183 lines (+71/-4)
6 files modified
TODO (+3/-0)
accounts/irc/data/telephony-irc-im.service (+2/-2)
handler/texthandler.cpp (+22/-0)
handler/texthandler.h (+4/-0)
libtelephonyservice/accountentry.cpp (+27/-2)
libtelephonyservice/accountentry.h (+13/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/telephony-service/connect-disconnect-accounts
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+318944@code.staging.launchpad.net

Commit message

Monitor app and disconnect/connect accounts when appropriate.

Description of the change

Monitor app and disconnect/connect accounts when appropriate.

To post a comment you must log in.
1240. By Tiago Salem Herrmann

merge parent branch

1241. By Tiago Salem Herrmann

merge parent branch

1242. By Tiago Salem Herrmann

temporary fix for online detection

1243. By Tiago Salem Herrmann

Disable auto-connect on irc protocols

1244. By Tiago Salem Herrmann

check if there is a connection before disconnecting

1245. By Tiago Salem Herrmann

add connection status property

1246. By Tiago Salem Herrmann

Use connectionStatus() instead of connection()->status()

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Just one request, looks good otherwise.

review: Needs Fixing
1247. By Tiago Salem Herrmann

add entry to TODO list

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good now,thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: