qtubuntu-media

Merge lp://staging/~phablet-team/qtubuntu-media/release-sink-properly into lp://staging/qtubuntu-media

  1. release-sink-properly
  2. Merge into trunk
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 118
Merged at revision: 117
Proposed branch: lp://staging/~phablet-team/qtubuntu-media/release-sink-properly
Merge into: lp://staging/qtubuntu-media
Diff against target: 15 lines (+5/-0)
1 file modified
src/aal/aalvideorenderercontrol.cpp (+5/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/qtubuntu-media/release-sink-properly
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+317180@code.staging.launchpad.net

Commit message

Release sink before creating a new one so resources are properly freed.

Description of the change

Release sink before creating a new one so resources are properly freed.

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

One minor thing to fix.

review: Needs Fixing (code)
lp://staging/~phablet-team/qtubuntu-media/release-sink-properly updated
118. By Alfonso Sanchez-Beato

Address review comments

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Review comment addressed, also added a comment for further clarification.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: