Merge lp://staging/~phablet-team/qtubuntu-media/multiple-sessions into lp://staging/qtubuntu-media

Proposed by Jim Hodapp
Status: Merged
Merged at revision: 32
Proposed branch: lp://staging/~phablet-team/qtubuntu-media/multiple-sessions
Merge into: lp://staging/qtubuntu-media
Prerequisite: lp://staging/~phablet-team/qtubuntu-media/add-media-hub-support
Diff against target: 403 lines (+162/-14)
11 files modified
debian/control (+1/-1)
src/aal/aalmediaplayercontrol.cpp (+0/-7)
src/aal/aalmediaplayercontrol.h (+3/-2)
src/aal/aalmediaplayerservice.cpp (+37/-1)
src/aal/aalmediaplayerservice.h (+6/-0)
unittests/player.cpp (+17/-1)
unittests/player.h (+3/-0)
unittests/service.cpp (+34/-0)
unittests/service.h (+54/-0)
unittests/tst_mediaplayerplugin.cpp (+4/-1)
unittests/unittests.pro (+3/-1)
To merge this branch: bzr merge lp://staging/~phablet-team/qtubuntu-media/multiple-sessions
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+217453@code.staging.launchpad.net

Commit message

* Pause other playing sessions when starting playback of a new foreground player
* Connect to the playback_status_changed signal from media-hub so that qtubuntu-media can update the app when PlaybackStatus changes (i.e. play, pause, stop, etc)
* Make seeking more accurate and resume exactly where playback left off after pressing pause and then play
* Make sure next/previous works in music-app
* Make sure unit tst_play() doesn't crash due to new m_hubService->pause_other_sessions(key) call in AalMediaPlayerService::play()
* Disable setting stopped state in onPlaybackStatusChanged for now since this causes next/previous to not work in music-app

Description of the change

* Pause other playing sessions when starting playback of a new foreground player
* Connect to the playback_status_changed signal from media-hub so that qtubuntu-media can update the app when PlaybackStatus changes (i.e. play, pause, stop, etc)
* Make seeking more accurate and resume exactly where playback left off after pressing pause and then play
* Make sure next/previous works in music-app
* Make sure unit tst_play() doesn't crash due to new m_hubService->pause_other_sessions(key) call in AalMediaPlayerService::play()
* Disable setting stopped state in onPlaybackStatusChanged for now since this causes next/previous to not work in music-app

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
70. By Jim Hodapp

Rely on a specific version or greater of libmedia-hub-dev so that the build order is correct

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
71. By Jim Hodapp

Add missing unittest files

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: